diff --git a/doc/qtcreator/config/style/qt5-sidebar.html b/doc/qtcreator/config/style/qt5-sidebar.html
index c5c9f62c161..e9bdbfb1da8 100644
--- a/doc/qtcreator/config/style/qt5-sidebar.html
+++ b/doc/qtcreator/config/style/qt5-sidebar.html
@@ -70,7 +70,7 @@
Reference
- - Acknowledgements
+ - Licenses and Acknowledgments
- Command-Line Options
- Custom Wizards
- FAQ
diff --git a/doc/qtcreator/src/howto/creator-only/creator-how-to-install.qdoc b/doc/qtcreator/src/howto/creator-only/creator-how-to-install.qdoc
index f64c870cfe0..fad52f18617 100644
--- a/doc/qtcreator/src/howto/creator-only/creator-how-to-install.qdoc
+++ b/doc/qtcreator/src/howto/creator-only/creator-how-to-install.qdoc
@@ -88,5 +88,6 @@
{Compiling \QC} and \l{https://wiki.qt.io/Building_Qt_Creator_from_Git}
{Building Qt Creator from Git}.
- \sa {Manage Kits}{How To: Manage Kits}, {Register installed Qt versions}
+ \sa {Manage Kits}{How To: Manage Kits}, {Register installed Qt versions},
+ {Install plugins}, {Licenses and Acknowledgments}
*/
diff --git a/doc/qtcreator/src/overview/creator-acknowledgements.qdoc b/doc/qtcreator/src/overview/creator-acknowledgements.qdoc
index e69626b35cf..f1ccb416af0 100644
--- a/doc/qtcreator/src/overview/creator-acknowledgements.qdoc
+++ b/doc/qtcreator/src/overview/creator-acknowledgements.qdoc
@@ -17,9 +17,15 @@
\ingroup creator-reference
- \title Acknowledgements
+ \title Licenses and Acknowledgments
- \brief Third-party components in \QC.
+ \brief Licenses and third-party components in \QC.
+
+ \section1 Licenses
+
+ \QC is available under commercial licenses from The Qt Company, and
+ under the GNU General Public License version 3, annotated with
+ The Qt Company GPL Exception 1.0.
\section1 Credits
diff --git a/doc/qtdesignstudio/src/qtdesignstudio-toc.qdoc b/doc/qtdesignstudio/src/qtdesignstudio-toc.qdoc
index abc575e8d9b..9000fbb2f5a 100644
--- a/doc/qtdesignstudio/src/qtdesignstudio-toc.qdoc
+++ b/doc/qtdesignstudio/src/qtdesignstudio-toc.qdoc
@@ -272,7 +272,7 @@
\li \l{Supported Platforms}
\endlist
\li \l{Technical Support}
- \li \l{Acknowledgements}
+ \li \l{Licenses and Acknowledgments}
\li \l{What's New}
\endlist
*/
diff --git a/share/qtcreator/templates/wizards/projects/qtquickapplication/CMakeLists.txt b/share/qtcreator/templates/wizards/projects/qtquickapplication/CMakeLists.txt
index 5ab817b9bfe..d7ae810c033 100644
--- a/share/qtcreator/templates/wizards/projects/qtquickapplication/CMakeLists.txt
+++ b/share/qtcreator/templates/wizards/projects/qtquickapplication/CMakeLists.txt
@@ -7,11 +7,11 @@ set(CMAKE_AUTOMOC ON)
@endif
set(CMAKE_CXX_STANDARD_REQUIRED ON)
-find_package(Qt6 %{MinimumSupportedQtVersion} REQUIRED COMPONENTS Quick)
+find_package(Qt6 REQUIRED COMPONENTS Quick)
@if %{HasQSPSetup}
@if %{UsesAutoResourcePrefix}
-qt_standard_project_setup(REQUIRES 6.5)
+qt_standard_project_setup(REQUIRES %{MinimumSupportedQtVersion})
@else
qt_standard_project_setup()
@endif
diff --git a/src/libs/tracing/qml/ImageToolButton.qml b/src/libs/tracing/qml/ImageToolButton.qml
index 45ca12b8997..ebbc8e28907 100644
--- a/src/libs/tracing/qml/ImageToolButton.qml
+++ b/src/libs/tracing/qml/ImageToolButton.qml
@@ -22,8 +22,7 @@ ToolButton {
smooth: false
}
- background: PaddedRectangle {
- padding: Theme.compactToolbar() ? 0 : 3
+ background: Rectangle {
radius: Theme.compactToolbar() ? 0 : 5
color: (parent.checked || parent.pressed)
? Theme.color(Theme.FancyToolButtonSelectedColor)
diff --git a/src/plugins/languageclient/callandtypehierarchy.cpp b/src/plugins/languageclient/callandtypehierarchy.cpp
index 4b8f7117132..71a9558f34e 100644
--- a/src/plugins/languageclient/callandtypehierarchy.cpp
+++ b/src/plugins/languageclient/callandtypehierarchy.cpp
@@ -287,6 +287,12 @@ public:
theWidget, [this](const QModelIndex &index) { onItemDoubleClicked(index); });
}
+ ~HierarchyWidgetHelper()
+ {
+ if (m_runningRequest && m_runningRequest->first)
+ m_runningRequest->first->cancelRequest(m_runningRequest->second);
+ }
+
void updateHierarchyAtCursorPosition()
{
m_model.clear();
@@ -315,6 +321,17 @@ protected:
item->forChildrenAtLevel(1, [&](const TreeItem *child) { m_view->expand(child->index()); });
}
+ void send(Client *client, const JsonRpcMessage &request, const MessageId &requestId)
+ {
+ m_runningRequest = std::make_pair(QPointer(client), requestId);
+ client->sendMessage(request);
+ }
+
+ void resetRunningRequest()
+ {
+ m_runningRequest.reset();
+ }
+
private:
virtual void sendRequest(Client *client, const TextDocumentPositionParams ¶ms,
const Core::IDocument *document) = 0;
@@ -334,6 +351,7 @@ private:
AnnotatedItemDelegate m_delegate;
NavigationTreeView * const m_view;
+ std::optional, MessageId>> m_runningRequest;
TreeModel m_model;
};
@@ -358,12 +376,13 @@ private:
const PrepareCallHierarchyRequest::Response &response) {
handlePrepareResponse(client, response);
});
- client->sendMessage(request);
+ send(client, request, request.id());
}
void handlePrepareResponse(Client *client,
const PrepareCallHierarchyRequest::Response &response)
{
+ resetRunningRequest();
if (!client)
return;
const std::optional error = response.error();
@@ -401,12 +420,13 @@ private:
const PrepareTypeHierarchyRequest::Response &response) {
handlePrepareResponse(client, response);
});
- client->sendMessage(request);
+ send(client, request, request.id());
}
void handlePrepareResponse(Client *client,
const PrepareTypeHierarchyRequest::Response &response)
{
+ resetRunningRequest();
if (!client)
return;
const std::optional error = response.error();
diff --git a/src/plugins/texteditor/fontsettings.cpp b/src/plugins/texteditor/fontsettings.cpp
index 3cb58fd1282..54e384984b3 100644
--- a/src/plugins/texteditor/fontsettings.cpp
+++ b/src/plugins/texteditor/fontsettings.cpp
@@ -103,6 +103,7 @@ bool FontSettings::fromSettings(const FormatDescriptions &descriptions, const Qt
m_fontSize = s->value(group + fontSizeKey, m_fontSize).toInt();
m_fontZoom= s->value(group + fontZoomKey, m_fontZoom).toInt();
m_lineSpacing = s->value(group + lineSpacingKey, m_lineSpacing).toInt();
+ QTC_ASSERT(m_lineSpacing >= 0, m_lineSpacing = 100);
m_antialias = s->value(group + antialiasKey, DEFAULT_ANTIALIAS).toBool();
if (s->contains(group + schemeFileNamesKey)) {
@@ -337,7 +338,7 @@ qreal FontSettings::lineSpacing() const
QFont currentFont = font();
currentFont.setPointSize(std::max(m_fontSize * m_fontZoom / 100, 1));
qreal spacing = QFontMetricsF(currentFont).lineSpacing();
- if (m_lineSpacing != 100)
+ if (QTC_GUARD(m_lineSpacing > 0) && m_lineSpacing != 100)
spacing *= qreal(m_lineSpacing) / 100;
return spacing;
}
diff --git a/src/plugins/texteditor/texteditor.cpp b/src/plugins/texteditor/texteditor.cpp
index 7f817f50307..bedc8179a6a 100644
--- a/src/plugins/texteditor/texteditor.cpp
+++ b/src/plugins/texteditor/texteditor.cpp
@@ -5185,6 +5185,7 @@ void TextEditorWidgetPrivate::updateLineAnnotation(const PaintEventData &data,
q->viewport()->update(annotationRect.rect.toAlignedRect());
}
m_annotationRects[data.block.blockNumber()] = newRects;
+ QTC_ASSERT(data.lineSpacing != 0, return);
const int maxVisibleLines = data.viewportRect.height() / data.lineSpacing;
if (m_annotationRects.size() >= maxVisibleLines * 2)
scheduleCleanupAnnotationCache();