feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git - fix bug with empty working directory in ChangeSelectionDialog

Browse Source 
and also remove unnedded command.

Change-Id: I6c20f2061fc3628693d80ad01fe23c1a835ca127
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Petar Perisin
2013-06-04 23:04:43 +02:00
parent 808afcfbb2
commit 45e6edaf3a
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/git/changeselectiondialog.cpp
View File

@@ -157,7 +157,7 @@ void ChangeSelectionDialog::chooseWorkingDirectory()
QString ChangeSelectionDialog::workingDirectory() const QString ChangeSelectionDialog::workingDirectory() const
{ {
if (!QDir(m_workingDirEdit->text()).exists()) if (m_workingDirEdit->text().isEmpty() || !QDir(m_workingDirEdit->text()).exists())
return QString(); return QString();
return GitPlugin::instance()->gitClient()-> return GitPlugin::instance()->gitClient()->
@@ -230,7 +230,6 @@ void ChangeSelectionDialog::recalculateDetails()
QString workingDir = workingDirectory(); QString workingDir = workingDirectory();
QPalette palette = m_workingDirEdit->palette(); QPalette palette = m_workingDirEdit->palette();
if (workingDir.isEmpty()) { if (workingDir.isEmpty()) {
m_workingDirEdit->palette();
m_detailsText->setPlainText(tr("Error: Bad working directory.")); m_detailsText->setPlainText(tr("Error: Bad working directory."));
palette.setColor(QPalette::Text, Qt::red); palette.setColor(QPalette::Text, Qt::red);
m_workingDirEdit->setPalette(palette); m_workingDirEdit->setPalette(palette);