From 45fb2c09860b00e3b4fc5a00a4602668dc682e3a Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Mon, 9 Oct 2023 15:01:51 +0200 Subject: [PATCH] CMakePM: Remove pointer check for null The pointer contains the parent class passed with "this" and will never be null. Coverity-Id: 1568097 Dereference after null check (FORWARD_NULL) Coverity-Id: 1568100 Uninitialized pointer field (UNINIT_CTOR) Coverity-Id: 1568111 Dereference before null check (REVERSE_INULL) Change-Id: I40e32d162689c749d498c4a63c073c0e336a3626 Reviewed-by: Reviewed-by: Eike Ziller --- src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp index 07d182b5ced..40562776967 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp @@ -171,8 +171,6 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc) m_configFilterModel(new CategorySortFilterModel(this)), m_configTextFilterModel(new CategorySortFilterModel(this)) { - QTC_ASSERT(m_buildConfig, return); - m_configureDetailsWidget = new DetailsWidget; updateConfigureDetailsWidgetsSummary(); @@ -682,7 +680,7 @@ void CMakeBuildSettingsWidget::updateConfigureDetailsWidgetsSummary( const CMakeTool *tool = CMakeKitAspect::cmakeTool(m_buildConfig->kit()); cmd.setExecutable(tool ? tool->cmakeExecutable() : "cmake"); - const FilePath buildDirectory = m_buildConfig ? m_buildConfig->buildDirectory() : "."; + const FilePath buildDirectory = m_buildConfig->buildDirectory(); cmd.addArgs({"-S", m_buildConfig->project()->projectDirectory().path()}); cmd.addArgs({"-B", buildDirectory.path()});