From 4645c713d2dc871e52e146456a11f084d428db5c Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 23 Oct 2023 16:13:51 +0200 Subject: [PATCH] GenericDeployStep: Fix rsync step Don't use a copy of m_files for mkdirTask(), as m_files is modified by the running recipe. So, when the recipe is prepared, the m_files doesn't contain the right data, yet. This is going to be refactored in master, as it seems the isDeploymentNecessary() operating on mutable internals is confusing. Fixes: QTCREATORBUG-29609 Change-Id: I3f34584ffd9486322e8b26f95ac72b96a9306f8b Reviewed-by: Christian Kandeler --- src/plugins/remotelinux/genericdeploystep.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/remotelinux/genericdeploystep.cpp b/src/plugins/remotelinux/genericdeploystep.cpp index 5def5465258..4ae804689c2 100644 --- a/src/plugins/remotelinux/genericdeploystep.cpp +++ b/src/plugins/remotelinux/genericdeploystep.cpp @@ -90,9 +90,9 @@ GroupItem GenericDeployStep::mkdirTask() { using ResultType = expected_str; - const auto onSetup = [files = m_files](Async &async) { + const auto onSetup = [this](Async &async) { FilePaths remoteDirs; - for (const FileToTransfer &file : std::as_const(files)) + for (const FileToTransfer &file : std::as_const(m_files)) remoteDirs << file.m_target.parentDir(); FilePath::sort(remoteDirs);