forked from qt-creator/qt-creator
		
	C++: code completion for lambda calls
support for lambdas, e.g.:
struct S { int bar; };
[]() { return new S; } ()->bar;
[] { return new S; } ()->bar;
[]() ->S* { return new S(); } ()->bar;
[]() throw() { return new S(); } ()->bar;
[]() throw()->S* { return new S(); } ()->bar;
Task-number: QTCREATORBUG-9523
Change-Id: I43fbf6f0ee0bb11411c53c984df75ef33a276466
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
			
			
This commit is contained in:
		
				
					committed by
					
						
						Erik Verbruggen
					
				
			
			
				
	
			
			
			
						parent
						
							ab15d38726
						
					
				
				
					commit
					46461fc183
				
			@@ -2690,3 +2690,138 @@ void CppToolsPlugin::test_completion_enum_inside_function_QTCREATORBUG5456()
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("e2")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("e3")));
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void CppToolsPlugin::test_completion_lambdaCalls_1()
 | 
			
		||||
{
 | 
			
		||||
    TestData data;
 | 
			
		||||
    data.srcText =
 | 
			
		||||
            "struct S { int bar; };\n"
 | 
			
		||||
            "void foo()\n"
 | 
			
		||||
            "{\n"
 | 
			
		||||
            "   @\n"
 | 
			
		||||
            "   // padding so we get the scope right\n"
 | 
			
		||||
            "}\n"
 | 
			
		||||
            ;
 | 
			
		||||
    setup(&data);
 | 
			
		||||
 | 
			
		||||
    Utils::ChangeSet change;
 | 
			
		||||
    QString txt = QLatin1String("[](){ return new S; } ()->");
 | 
			
		||||
    change.insert(data.pos, txt);
 | 
			
		||||
    QTextCursor cursor(data.doc);
 | 
			
		||||
    change.apply(&cursor);
 | 
			
		||||
    data.pos += txt.length();
 | 
			
		||||
 | 
			
		||||
    QStringList completions = getCompletions(data);
 | 
			
		||||
 | 
			
		||||
    QCOMPARE(completions.size(), 2);
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("S")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("bar")));
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void CppToolsPlugin::test_completion_lambdaCalls_2()
 | 
			
		||||
{
 | 
			
		||||
    TestData data;
 | 
			
		||||
    data.srcText =
 | 
			
		||||
            "struct S { int bar; };\n"
 | 
			
		||||
            "void foo()\n"
 | 
			
		||||
            "{\n"
 | 
			
		||||
            "   @\n"
 | 
			
		||||
            "   // padding so we get the scope right\n"
 | 
			
		||||
            "}\n"
 | 
			
		||||
            ;
 | 
			
		||||
    setup(&data);
 | 
			
		||||
 | 
			
		||||
    Utils::ChangeSet change;
 | 
			
		||||
    QString txt = QLatin1String("[] { return new S; } ()->");
 | 
			
		||||
    change.insert(data.pos, txt);
 | 
			
		||||
    QTextCursor cursor(data.doc);
 | 
			
		||||
    change.apply(&cursor);
 | 
			
		||||
    data.pos += txt.length();
 | 
			
		||||
 | 
			
		||||
    QStringList completions = getCompletions(data);
 | 
			
		||||
 | 
			
		||||
    QCOMPARE(completions.size(), 2);
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("S")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("bar")));
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void CppToolsPlugin::test_completion_lambdaCalls_3()
 | 
			
		||||
{
 | 
			
		||||
    TestData data;
 | 
			
		||||
    data.srcText =
 | 
			
		||||
            "struct S { int bar; };\n"
 | 
			
		||||
            "void foo()\n"
 | 
			
		||||
            "{\n"
 | 
			
		||||
            "   @\n"
 | 
			
		||||
            "   // padding so we get the scope right\n"
 | 
			
		||||
            "}\n"
 | 
			
		||||
            ;
 | 
			
		||||
    setup(&data);
 | 
			
		||||
 | 
			
		||||
    Utils::ChangeSet change;
 | 
			
		||||
    QString txt = QLatin1String("[]() ->S* { return new S; } ()->");
 | 
			
		||||
    change.insert(data.pos, txt);
 | 
			
		||||
    QTextCursor cursor(data.doc);
 | 
			
		||||
    change.apply(&cursor);
 | 
			
		||||
    data.pos += txt.length();
 | 
			
		||||
 | 
			
		||||
    QStringList completions = getCompletions(data);
 | 
			
		||||
 | 
			
		||||
    QCOMPARE(completions.size(), 2);
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("S")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("bar")));
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void CppToolsPlugin::test_completion_lambdaCalls_4()
 | 
			
		||||
{
 | 
			
		||||
    TestData data;
 | 
			
		||||
    data.srcText =
 | 
			
		||||
            "struct S { int bar; };\n"
 | 
			
		||||
            "void foo()\n"
 | 
			
		||||
            "{\n"
 | 
			
		||||
            "   @\n"
 | 
			
		||||
            "   // padding so we get the scope right\n"
 | 
			
		||||
            "}\n"
 | 
			
		||||
            ;
 | 
			
		||||
    setup(&data);
 | 
			
		||||
 | 
			
		||||
    Utils::ChangeSet change;
 | 
			
		||||
    QString txt = QLatin1String("[]() throw() { return new S; } ()->");
 | 
			
		||||
    change.insert(data.pos, txt);
 | 
			
		||||
    QTextCursor cursor(data.doc);
 | 
			
		||||
    change.apply(&cursor);
 | 
			
		||||
    data.pos += txt.length();
 | 
			
		||||
 | 
			
		||||
    QStringList completions = getCompletions(data);
 | 
			
		||||
 | 
			
		||||
    QCOMPARE(completions.size(), 2);
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("S")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("bar")));
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void CppToolsPlugin::test_completion_lambdaCalls_5()
 | 
			
		||||
{
 | 
			
		||||
    TestData data;
 | 
			
		||||
    data.srcText =
 | 
			
		||||
            "struct S { int bar; };\n"
 | 
			
		||||
            "void foo()\n"
 | 
			
		||||
            "{\n"
 | 
			
		||||
            "   @\n"
 | 
			
		||||
            "   // padding so we get the scope right\n"
 | 
			
		||||
            "}\n"
 | 
			
		||||
            ;
 | 
			
		||||
    setup(&data);
 | 
			
		||||
 | 
			
		||||
    Utils::ChangeSet change;
 | 
			
		||||
    QString txt = QLatin1String("[]() throw()->S* { return new S; } ()->");
 | 
			
		||||
    change.insert(data.pos, txt);
 | 
			
		||||
    QTextCursor cursor(data.doc);
 | 
			
		||||
    change.apply(&cursor);
 | 
			
		||||
    data.pos += txt.length();
 | 
			
		||||
 | 
			
		||||
    QStringList completions = getCompletions(data);
 | 
			
		||||
 | 
			
		||||
    QCOMPARE(completions.size(), 2);
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("S")));
 | 
			
		||||
    QVERIFY(completions.contains(QLatin1String("bar")));
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -156,6 +156,13 @@ private slots:
 | 
			
		||||
    void test_completion_enum_inside_block_inside_function_QTCREATORBUG5456();
 | 
			
		||||
    void test_completion_enum_inside_function_QTCREATORBUG5456();
 | 
			
		||||
 | 
			
		||||
    //lambda
 | 
			
		||||
    void test_completion_lambdaCalls_1();
 | 
			
		||||
    void test_completion_lambdaCalls_2();
 | 
			
		||||
    void test_completion_lambdaCalls_3();
 | 
			
		||||
    void test_completion_lambdaCalls_4();
 | 
			
		||||
    void test_completion_lambdaCalls_5();
 | 
			
		||||
 | 
			
		||||
    void test_format_pointerdeclaration_in_simpledeclarations();
 | 
			
		||||
    void test_format_pointerdeclaration_in_simpledeclarations_data();
 | 
			
		||||
    void test_format_pointerdeclaration_in_controlflowstatements();
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user