feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ShortCutManager: Avoid using sender()

Browse Source 
Change-Id: Ibe0c2835463e1397b960526383afed73df50b62a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Jarek Kobus
2023-12-13 21:31:37 +01:00
committed by Tim Jenssen
parent 7969fb2147
commit 466856ca79
2 changed files with 12 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/plugins/qmldesigner/shortcutmanager.cpp
View File

@@ -330,16 +330,24 @@ void ShortCutManager::selectAll()
void ShortCutManager::connectUndoActions(DesignDocument *designDocument) void ShortCutManager::connectUndoActions(DesignDocument *designDocument)
{ {
if (designDocument) { if (designDocument) {
connect(designDocument, &DesignDocument::undoAvailable, this, &ShortCutManager::undoAvailable); connect(designDocument, &DesignDocument::undoAvailable, this,
connect(designDocument, &DesignDocument::redoAvailable, this, &ShortCutManager::redoAvailable); [this, designDocument](bool isAvailable) {
if (currentDesignDocument() == designDocument)
m_undoAction.setEnabled(isAvailable);
});
connect(designDocument, &DesignDocument::redoAvailable, this,
[this, designDocument](bool isAvailable) {
if (currentDesignDocument() == designDocument)
m_redoAction.setEnabled(isAvailable);
});
} }
} }
void ShortCutManager::disconnectUndoActions(DesignDocument *designDocument) void ShortCutManager::disconnectUndoActions(DesignDocument *designDocument)
{ {
if (designDocument) { if (designDocument) {
disconnect(designDocument, &DesignDocument::undoAvailable, this, &ShortCutManager::undoAvailable); disconnect(designDocument, &DesignDocument::undoAvailable, this, nullptr);
disconnect(designDocument, &DesignDocument::redoAvailable, this, &ShortCutManager::redoAvailable); disconnect(designDocument, &DesignDocument::redoAvailable, this, nullptr);
} }
} }
@@ -354,24 +362,6 @@ void ShortCutManager::updateUndoActions(DesignDocument *designDocument)
} }
} }
void ShortCutManager::undoAvailable(bool isAvailable)
{
auto documentController = qobject_cast<DesignDocument*>(sender());
if (currentDesignDocument() &&
currentDesignDocument() == documentController) {
m_undoAction.setEnabled(isAvailable);
}
}
void ShortCutManager::redoAvailable(bool isAvailable)
{
auto documentController = qobject_cast<DesignDocument*>(sender());
if (currentDesignDocument() &&
currentDesignDocument() == documentController) {
m_redoAction.setEnabled(isAvailable);
}
}
void ShortCutManager::goIntoComponent() void ShortCutManager::goIntoComponent()
{ {
if (currentDesignDocument() if (currentDesignDocument()

2
src/plugins/qmldesigner/shortcutmanager.h
View File

@@ -41,8 +41,6 @@ private:
void duplicateSelected(); void duplicateSelected();
void paste(); void paste();
void selectAll(); void selectAll();
void undoAvailable(bool isAvailable);
void redoAvailable(bool isAvailable);
void goIntoComponent(); void goIntoComponent();
private: private: