feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BuildManager: Remove busy loop

Browse Source 
This code froze the entire UI for the time that a build step took to
cancel, for no apparent reason.

Change-Id: I40f20b9875d92e8919debaeac2021d389b6b6c28
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-02-15 12:25:54 +01:00
parent 72d962e949
commit 466eb1d30f
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/buildmanager.cpp
View File

@@ -193,8 +193,6 @@ void BuildManager::cancel()
return; return;
d->m_canceling = true; d->m_canceling = true;
d->m_currentBuildStep->cancel(); d->m_currentBuildStep->cancel();
while (d->m_canceling)
QApplication::processEvents(QEventLoop::ExcludeUserInputEvents); // TODO: Is this really necessary?
} }
} }