feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Simplify signaling

Browse Source 
Change-Id: I50fdaed0d813b5004c1756e9c5a6efd3ce7a3318
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-07-18 16:48:02 +02:00
parent 09b127f9f1
commit 46f39f5601
7 changed files with 18 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -146,7 +146,6 @@ void CMakeBuildConfiguration::ctor()
this, [this, project]() {
clearError();
project->updateProjectData(this);
emit dataAvailable();
});
connect(m_buildDirManager.get(), &BuildDirManager::errorOccured,
this, [this, project](const QString &msg) {
@@ -155,9 +154,8 @@ void CMakeBuildConfiguration::ctor()
});
connect(m_buildDirManager.get(), &BuildDirManager::configurationStarted,
this, [this, project]() {
project->handleParsingStarted();
project->handleParsingStarted(this);
clearError(ForceEnabledChanged::True);
emit parsingStarted();
});
connect(this, &CMakeBuildConfiguration::environmentChanged,
@@ -411,7 +409,7 @@ CMakeConfig CMakeBuildConfiguration::cmakeConfiguration() const
void CMakeBuildConfiguration::setError(const QString &message)
{
QString oldMessage = m_error;
const QString oldMessage = m_error;
if (m_error != message)
m_error = message;
if (oldMessage.isEmpty() && !message.isEmpty())