feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: require no undefined symbols

Browse Source 
The ELF default is historical legacy. We should always require all
libraries and all plugins to link to their dependencies and not
accidentally forget something (like implementing a virtual function).

Change-Id: I5e00996d7f4b4a10bc98fffd1629f8bfcf0d1c8f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
This commit is contained in:
Thiago Macieira
2020-08-10 10:36:34 -07:00
parent 36c49cd2ea
commit 46f6c5d005
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cmake/QtCreatorAPI.cmake
View File

@@ -244,6 +244,7 @@ function(add_qtc_library name)
unset(NAMELINK_OPTION) unset(NAMELINK_OPTION)
if (library_type STREQUAL "SHARED") if (library_type STREQUAL "SHARED")
set(NAMELINK_OPTION NAMELINK_SKIP) set(NAMELINK_OPTION NAMELINK_SKIP)
qtc_add_link_flags_no_undefined(${name})
endif() endif()
unset(COMPONENT_OPTION) unset(COMPONENT_OPTION)

14
cmake/QtCreatorAPIInternal.cmake
View File

@@ -4,6 +4,7 @@ if (CMAKE_VERSION VERSION_LESS 3.18)
endif() endif()
endif() endif()
include(CheckLinkerFlag)
include(FeatureSummary) include(FeatureSummary)
# #
@@ -161,6 +162,19 @@ function(qtc_enable_sanitize _sanitize_flags)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG}" PARENT_SCOPE) set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG}" PARENT_SCOPE)
endfunction() endfunction()
function(qtc_add_link_flags_no_undefined target)
set(no_undefined_flag "-Wl,--no-undefined")
check_linker_flag(CXX ${no_undefined_flag} QTC_LINKER_SUPPORTS_NO_UNDEFINED)
if (NOT QTC_LINKER_SUPPORTS_NO_UNDEFINED)
set(no_undefined_flag "-Wl,-undefined,error")
check_linker_flag(CXX ${no_undefined_flag} QTC_LINKER_SUPPORTS_UNDEFINED_ERROR)
if (NOT QTC_LINKER_SUPPORTS_UNDEFINED_ERROR)
return()
endif()
endif()
target_link_options("${target}" PRIVATE "${no_undefined_flag}")
endfunction()
function(append_extra_translations target_name) function(append_extra_translations target_name)
if(NOT ARGN) if(NOT ARGN)
return() return()