feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Squish: Fix missing impl for deleting shared scripts

Browse Source 
The action has been present for some time, but so far it had been
unimplemented

Change-Id: I798a144116ffeba60fb368430b30705ffc9b3f1c
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2024-02-02 13:44:11 +01:00
parent 35b7f868f5
commit 46fd19591f
1 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/plugins/squish/squishnavigationwidget.cpp
View File

@@ -47,6 +47,7 @@ private:
void onRowsInserted(const QModelIndex &parent, int, int); void onRowsInserted(const QModelIndex &parent, int, int);
void onRowsRemoved(const QModelIndex &parent, int, int); void onRowsRemoved(const QModelIndex &parent, int, int);
void onAddSharedFileTriggered(const QModelIndex &idx); void onAddSharedFileTriggered(const QModelIndex &idx);
void onRemoveSharedFileTriggered(const QModelIndex &idx);
void onRemoveSharedFolderTriggered(int row, const QModelIndex &parent); void onRemoveSharedFolderTriggered(int row, const QModelIndex &parent);
void onRemoveAllSharedFolderTriggered(); void onRemoveAllSharedFolderTriggered();
void onRecordTestCase(const QString &suiteName, const QString &testCase); void onRecordTestCase(const QString &suiteName, const QString &testCase);
@@ -161,6 +162,9 @@ void SquishNavigationWidget::contextMenuEvent(QContextMenuEvent *event)
case SquishTestTreeItem::SquishSharedFile: { case SquishTestTreeItem::SquishSharedFile: {
QAction *deleteSharedFile = new QAction(Tr::tr("Delete Shared File"), &menu); QAction *deleteSharedFile = new QAction(Tr::tr("Delete Shared File"), &menu);
menu.addAction(deleteSharedFile); menu.addAction(deleteSharedFile);
connect(deleteSharedFile, &QAction::triggered, this, [this, idx] {
onRemoveSharedFileTriggered(idx);
});
break; break;
} }
case SquishTestTreeItem::SquishSharedFolder: { case SquishTestTreeItem::SquishSharedFolder: {
@@ -325,6 +329,31 @@ void SquishNavigationWidget::onAddSharedFileTriggered(const QModelIndex &idx)
m_view->edit(m_sortModel->mapFromSource(added)); m_view->edit(m_sortModel->mapFromSource(added));
} }
void SquishNavigationWidget::onRemoveSharedFileTriggered(const QModelIndex &idx)
{
const auto scriptFile = FilePath::fromVariant(idx.data(LinkRole));
QTC_ASSERT(!scriptFile.isEmpty(), return);
const QString detail = Tr::tr("Do you really want to delete \"%1\" permanently?")
.arg(scriptFile.toUserOutput());
const QMessageBox::StandardButton pressed
= CheckableMessageBox::question(Core::ICore::dialogParent(),
Tr::tr("Remove Shared File"),
detail,
Key("RemoveSharedSquishScript"));
if (pressed != QMessageBox::Yes)
return;
const QModelIndex &realIdx = m_sortModel->mapToSource(idx);
// close document silently if open
if (Core::IDocument *doc = Core::DocumentModel::documentForFilePath(scriptFile))
Core::EditorManager::closeDocuments({doc}, false);
if (scriptFile.removeFile())
m_model->removeTreeItem(realIdx.row(), realIdx.parent());
else
SquishMessages::criticalMessage(Tr::tr("Failed to remove \"%1\"."));
}
void SquishNavigationWidget::onRemoveSharedFolderTriggered(int row, const QModelIndex &parent) void SquishNavigationWidget::onRemoveSharedFolderTriggered(int row, const QModelIndex &parent)
{ {
const auto folder = Utils::FilePath::fromVariant(m_sortModel->index(row, 0, parent).data(LinkRole)); const auto folder = Utils::FilePath::fromVariant(m_sortModel->index(row, 0, parent).data(LinkRole));