From 4762d54401658e28be7fa04491d5ed6a5491e129 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Wed, 6 Apr 2022 09:42:48 +0200 Subject: [PATCH] DockerDevice: Connect to QtcProcess::done() signal Instead of connecting to errorOccurred() and finished() signals. Change-Id: I0dd1d35aa48bfb7769623ff5735a7abd644d180f Reviewed-by: hjk --- src/plugins/docker/dockerdevice.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/plugins/docker/dockerdevice.cpp b/src/plugins/docker/dockerdevice.cpp index 6f2b5f712b4..314119ead30 100644 --- a/src/plugins/docker/dockerdevice.cpp +++ b/src/plugins/docker/dockerdevice.cpp @@ -273,13 +273,12 @@ DockerDevice::DockerDevice(const DockerDeviceData &data) return; } - QtcProcess *proc = new QtcProcess; + QtcProcess *proc = new QtcProcess(d); proc->setTerminalMode(TerminalMode::On); - QObject::connect(proc, &QtcProcess::finished, proc, &QObject::deleteLater); - - QObject::connect(proc, &QtcProcess::errorOccurred, [proc] { - MessageManager::writeDisrupting(tr("Error starting remote shell.")); + QObject::connect(proc, &QtcProcess::done, [proc] { + if (proc->error() != QProcess::UnknownError && MessageManager::instance()) + MessageManager::writeDisrupting(tr("Error starting remote shell.")); proc->deleteLater(); });