feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Split ApplicationLauncher::start() parameters

Browse Source 
There's traditionally an odd duplication of the runnable.device
and the passed device here. Start disentangling things.

Change-Id: I1cc1628c99cea04d761fc4d8dd0cb232127ce055
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2022-02-15 12:44:04 +01:00
parent 13ed522d8d
commit 47957de2dc
9 changed files with 51 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/valgrind/callgrind/callgrindcontroller.cpp
View File

@@ -126,11 +126,12 @@ void CallgrindController::run(Option option)
controller.command.setExecutable(FilePath::fromString(CALLGRIND_CONTROL_BINARY));
controller.command.setArguments(QString("%1 %2").arg(toOptionString(option)).arg(m_pid));
m_controllerProcess->setRunnable(controller);
if (!m_valgrindRunnable.device
|| m_valgrindRunnable.device->type() == ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE)
m_controllerProcess->start(controller);
m_controllerProcess->start();
else
m_controllerProcess->start(controller, m_valgrindRunnable.device);
m_controllerProcess->start(m_valgrindRunnable.device);
}
void CallgrindController::setValgrindPid(qint64 pid)