UnitTest: Cleanup

Improve naming and introduce googletest.h. Change-Id: I445c13db4c23d6dd5682ce0db3b83055cc6b8a89 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2016-09-15 17:41:41 +02:00
parent f717064a91
commit 47c01daeb2
67 changed files with 227 additions and 348 deletions
--- a/tests/unit/unittest/clangisdiagnosticrelatedtolocation-test.cpp
+++ b/tests/unit/unittest/clangisdiagnosticrelatedtolocation-test.cpp
@@ -0,0 +1,146 @@
+/****************************************************************************
+**
+** Copyright (C) 2016 The Qt Company Ltd.
+** Contact: https://www.qt.io/licensing/
+**
+** This file is part of Qt Creator.
+**
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and The Qt Company. For licensing terms
+** and conditions see https://www.qt.io/terms-conditions. For further
+** information use the contact form at https://www.qt.io/contact-us.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3 as published by the Free Software
+** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
+** included in the packaging of this file. Please review the following
+** information to ensure the GNU General Public License requirements will
+** be met: https://www.gnu.org/licenses/gpl-3.0.html.
+**
+****************************************************************************/
+
+#include "googletest.h"
+
+#include <clangisdiagnosticrelatedtolocation.h>
+#include <diagnosticcontainer.h>
+
+using ClangBackEnd::DiagnosticContainer;
+using ClangBackEnd::SourceLocationContainer;
+using ClangBackEnd::SourceRangeContainer;
+using ClangCodeModel::Internal::isDiagnosticRelatedToLocation;
+
+namespace {
+
+SourceRangeContainer createRange(uint startLine,
+                                 uint startColumn,
+                                 uint endLine,
+                                 uint endColumn)
+{
+    const SourceLocationContainer startLocation(Utf8String(), startLine, startColumn);
+    const SourceLocationContainer endLocation(Utf8String(), endLine, endColumn);
+
+    return SourceRangeContainer(startLocation, endLocation);
+}
+
+DiagnosticContainer createDiagnosticWithLocation(uint line, uint column)
+{
+    const SourceLocationContainer location(Utf8String(), line, column);
+
+    return DiagnosticContainer(Utf8String(),
+                               Utf8String(),
+                               std::pair<Utf8String, Utf8String>(),
+                               ClangBackEnd::DiagnosticSeverity::Error,
+                               location,
+                               QVector<SourceRangeContainer>(),
+                               QVector<ClangBackEnd::FixItContainer>(),
+                               QVector<DiagnosticContainer>());
+}
+
+DiagnosticContainer createDiagnosticWithRange(uint startLine,
+                                              uint startColumn,
+                                              uint endLine,
+                                              uint endColumn)
+{
+    const SourceRangeContainer range = createRange(startLine, startColumn, endLine, endColumn);
+
+    return DiagnosticContainer(Utf8String(),
+                               Utf8String(),
+                               std::pair<Utf8String, Utf8String>(),
+                               ClangBackEnd::DiagnosticSeverity::Error,
+                               SourceLocationContainer(),
+                               {range},
+                               QVector<ClangBackEnd::FixItContainer>(),
+                               QVector<DiagnosticContainer>());
+}
+
+class ClangIsDiagnosticRelatedToLocation : public ::testing::Test
+{
+public:
+    ClangIsDiagnosticRelatedToLocation() {}
+
+protected:
+    const QVector<SourceRangeContainer> emptyRanges;
+};
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, MatchLocation)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithLocation(5, 5);
+
+    ASSERT_TRUE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 5));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, DoNotMatchLocation)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithLocation(5, 5);
+
+    ASSERT_FALSE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 4));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, MatchStartRange)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithRange(5, 5, 5, 10);
+
+    ASSERT_TRUE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 5));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, MatchWithinRange)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithRange(5, 5, 5, 10);
+
+    ASSERT_TRUE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 7));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, MatchEndRange)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithRange(5, 5, 5, 10);
+
+    ASSERT_TRUE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 10));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, DoNoMatchBeforeRangeStart)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithRange(5, 5, 5, 10);
+
+    ASSERT_FALSE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 4));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, DoNoMatchAfterRangeEnd)
+{
+    const DiagnosticContainer diagnostic = createDiagnosticWithRange(5, 5, 5, 10);
+
+    ASSERT_FALSE(isDiagnosticRelatedToLocation(diagnostic, emptyRanges, 5, 11));
+}
+
+TEST_F(ClangIsDiagnosticRelatedToLocation, MatchInAdditionalRange)
+{
+    const QVector<SourceRangeContainer> additionalRanges{ createRange(5, 5, 5, 10) };
+    const DiagnosticContainer diagnostic = createDiagnosticWithLocation(1, 1);
+
+    ASSERT_TRUE(isDiagnosticRelatedToLocation(diagnostic, additionalRanges, 5, 7));
+}
+
+} // anonymous