Valgrind: De-slot

Change-Id: Id72d2463201107ae53d8be3d0f3ac30ec88530a4
Reviewed-by: hjk <hjk@qt.io>

src/plugins/valgrind/callgrind/callgrindcontroller.h

@@ -68,22 +68,20 @@ public:
      */
     void getLocalDataFile();
 
-Q_SIGNALS:
+signals:
     void finished(Valgrind::Callgrind::CallgrindController::Option option);
 
     void localParseDataAvailable(const QString &file);
 
     void statusMessage(const QString &msg);
 
-private Q_SLOTS:
+private:
     void processError(QProcess::ProcessError);
     void processFinished(int, QProcess::ExitStatus);
 
     void foundRemoteFile();
     void sftpInitialized();
     void sftpJobFinished(QSsh::SftpJobId job, const QString &error);
-
-private:
     void cleanupTempFile();
 
     // callgrind_control process

src/plugins/valgrind/callgrind/callgrinddatamodel.h

@@ -78,7 +78,6 @@ public:
         FileNameRole
     };
 
-public slots:
     /// enable/disable cycle detection
     void enableCycleDetection(bool enabled);
     void setShortenTemplates(bool enabled);

src/plugins/valgrind/callgrind/callgrindparser.h

@@ -56,13 +56,11 @@ public:
     // get and take ownership of the parsing results. If this function is not called the repository
     // will be destroyed when the parser is destroyed. Subsequent calls return null.
     ParseData *takeData();
+    void parse(QIODevice *stream);
 
 signals:
     void parserDataReady();
 
-public Q_SLOTS:
-    void parse(QIODevice *stream);
-
 private:
     class Private;
     Private *const d;

src/plugins/valgrind/callgrind/callgrindproxymodel.h

@@ -49,7 +49,6 @@ public:
     /// Only functions with an inclusive cost ratio above this minimum will be shown in the model
     double minimumInclusiveCostRatio() const { return m_minimumInclusiveCostRatio; }
 
-public Q_SLOTS:
     /// This will filter out all entries that are not located within \param baseDir
     void setFilterBaseDir(const QString& baseDir);
     void setFilterFunction(const Function *call);
@@ -59,7 +58,7 @@ public Q_SLOTS:
     /// by this model. If @c 0 is passed as argument, all rows will be shown.
     void setMinimumInclusiveCostRatio(double minimumInclusiveCost);
 
-Q_SIGNALS:
+signals:
     void filterFunctionChanged(const Function *previous, const Function *current);
     void filterMaximumRowsChanged(int rows);
 

src/plugins/valgrind/callgrind/callgrindstackbrowser.h

@@ -46,7 +46,6 @@ public:
     bool hasPrevious() const { return !m_stack.isEmpty(); }
     bool hasNext() const { return !m_redoStack.isEmpty(); }
 
-public slots:
     void goBack();
     void goNext();
 

src/plugins/valgrind/callgrindengine.h

@@ -44,7 +44,6 @@ public:
 
     Valgrind::Callgrind::ParseData *takeParserData();
 
-public slots:
     /// controller actions
     void dump();
     void reset();

src/plugins/valgrind/callgrindvisualisation.h

@@ -57,17 +57,14 @@ public:
 
     void setMinimumInclusiveCostRatio(double ratio);
 
-public slots:
     void setText(const QString &message);
 
 signals:
     void functionActivated(const Valgrind::Callgrind::Function *);
     void functionSelected(const Valgrind::Callgrind::Function *);
 
-protected slots:
-    void populateScene();
-
 protected:
+    void populateScene();
     void mousePressEvent(QMouseEvent *event);
     void mouseDoubleClickEvent(QMouseEvent *event);
     void resizeEvent(QResizeEvent *event);

src/plugins/valgrind/memcheck/memcheckrunner.h

@@ -51,14 +51,13 @@ public:
 signals:
     void logMessageReceived(const QByteArray &);
 
-private slots:
+private:
     void localHostAddressRetrieved(const QHostAddress &localHostAddress);
 
     void xmlSocketConnected();
     void logSocketConnected();
     void readLogSocket();
 
-private:
     QString tool() const;
 
     bool startServers(const QHostAddress &localHostAddress);

src/plugins/valgrind/memcheckerrorview.h

@@ -46,14 +46,10 @@ public:
     void setDefaultSuppressionFile(const QString &suppFile);
     QString defaultSuppressionFile() const;
     ValgrindBaseSettings *settings() const { return m_settings; }
-
-public slots:
     void settingsChanged(ValgrindBaseSettings *settings);
 
-private slots:
-    void suppressError();
-
 private:
+    void suppressError();
     QList<QAction *> customActions() const override;
 
     QAction *m_suppressAction;

src/plugins/valgrind/suppressiondialog.h

@@ -52,10 +52,8 @@ public:
                       const QList<XmlProtocol::Error> &errors);
     static void maybeShow(MemcheckErrorView *view);
 
-private slots:
-    void validate();
-
 private:
+    void validate();
     void accept();
     void reject();
 

src/plugins/valgrind/valgrindconfigwidget.h

@@ -50,17 +50,15 @@ public:
     void setSuppressions(const QStringList &files);
     QStringList suppressions() const;
 
-public Q_SLOTS:
     void slotAddSuppression();
     void slotRemoveSuppression();
     void slotSuppressionsRemoved(const QStringList &files);
     void slotSuppressionsAdded(const QStringList &files);
     void slotSuppressionSelectionChanged();
 
-private slots:
+private:
     void updateUi();
 
-private:
     ValgrindBaseSettings *m_settings;
     Ui::ValgrindConfigWidget *m_ui;
     QStandardItemModel *m_model;

src/plugins/valgrind/valgrindmemcheckparsertest.h

@@ -69,7 +69,7 @@ public:
     QVector<QPair<qint64,qint64> > errorcounts;
     QVector<QPair<QString,qint64> > suppcounts;
 
-public Q_SLOTS:
+public:
     void error(const Valgrind::XmlProtocol::Error &err)
     {
         errors.append(err);
@@ -108,7 +108,6 @@ public:
                 this, &RunnerDumper::processErrorReceived);
     }
 
-public slots:
     void error(const Valgrind::XmlProtocol::Error &e)
     {
         qDebug() << "error received";

src/plugins/valgrind/valgrindrunner.h

@@ -67,16 +67,14 @@ public:
 
     ValgrindProcess *valgrindProcess() const;
 
-protected:
-    virtual QString tool() const = 0;
-
 signals:
     void processOutputReceived(const QString &, Utils::OutputFormat);
     void processErrorReceived(const QString &, QProcess::ProcessError);
     void started();
     void finished();
 
-protected slots:
+protected:
+    virtual QString tool() const = 0;
     virtual void processError(QProcess::ProcessError);
     virtual void processFinished(int, QProcess::ExitStatus);
     virtual void localHostAddressRetrieved(const QHostAddress &localHostAddress);

src/plugins/valgrind/valgrindsettings.h

@@ -74,7 +74,6 @@ public:
     QString valgrindExecutable() const;
     SelfModifyingCodeDetection selfModifyingCodeDetection() const;
 
-public slots:
     void setValgrindExecutable(const QString &);
     void setSelfModifyingCodeDetection(int);
 
@@ -102,7 +101,6 @@ public:
     virtual void addSuppressionFiles(const QStringList &) = 0;
     virtual void removeSuppressionFiles(const QStringList &) = 0;
 
-public slots:
     void setNumCallers(int);
     void setLeakCheckOnFinish(int);
     void setShowReachable(bool);
@@ -144,7 +142,6 @@ public:
     /// \return Minimum cost ratio, range [0.0..100.0]
     double visualisationMinimumInclusiveCostRatio() const { return m_visualisationMinimumInclusiveCostRatio; }
 
-public slots:
     void setEnableCacheSim(bool enable);
     void setEnableBranchSim(bool enable);
     void setCollectSystime(bool collect);
@@ -226,7 +223,6 @@ public:
     bool detectCycles() const;
     bool shortenTemplates() const;
 
-public slots:
     void setCostFormat(Valgrind::Internal::CostDelegate::CostFormat format);
     void setDetectCycles(bool on);
     void setShortenTemplates(bool on);

src/plugins/valgrind/xmlprotocol/parser.h

@@ -58,11 +58,9 @@ public:
     ~Parser();
 
     QString errorString() const;
-
-public Q_SLOTS:
     void parse(QIODevice *stream);
 
-Q_SIGNALS:
+signals:
     void status(const Valgrind::XmlProtocol::Status &status);
     void error(const Valgrind::XmlProtocol::Error &error);
     void internalError(const QString &errorString);

src/plugins/valgrind/xmlprotocol/stackmodel.h

@@ -67,8 +67,6 @@ public:
     int columnCount(const QModelIndex &parent = QModelIndex()) const;
 
     void clear();
-
-public Q_SLOTS:
     void setError(const Valgrind::XmlProtocol::Error &error);
 
 private:

src/plugins/valgrind/xmlprotocol/threadedparser.h

@@ -56,14 +56,13 @@ public:
     bool waitForFinished();
     bool isRunning() const;
 
-public Q_SLOTS:
     ///@warning will move @p stream to a different thread and take ownership of it
     void parse(QIODevice *stream);
 
-private Q_SLOTS:
+private:
     void slotInternalError(const QString &errorString);
 
-Q_SIGNALS:
+signals:
     void status(const Valgrind::XmlProtocol::Status &status);
     void error(const Valgrind::XmlProtocol::Error &error);
     void internalError(const QString &errorString);