From 48a5fb4b138940348dcb96637594167acba1117d Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Fri, 14 Feb 2014 10:27:05 +0200 Subject: [PATCH] PushToGerrit: Do not calculate number of commits for empty input Change-Id: Ib2e5305dd47b486a963edf5bb04e6d16d76d5e68 Reviewed-by: Tobias Hunger --- src/plugins/git/gerrit/gerritpushdialog.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/git/gerrit/gerritpushdialog.cpp b/src/plugins/git/gerrit/gerritpushdialog.cpp index 82a60cfed83..13a5eb9a4d1 100644 --- a/src/plugins/git/gerrit/gerritpushdialog.cpp +++ b/src/plugins/git/gerrit/gerritpushdialog.cpp @@ -201,9 +201,12 @@ void GerritPushDialog::setChangeRange() setRemoteBranches(true); return; } + const QString remoteBranchName = selectedRemoteBranchName(); + if (remoteBranchName.isEmpty()) + return; QString remote = selectedRemoteName(); remote += QLatin1Char('/'); - remote += selectedRemoteBranchName(); + remote += remoteBranchName; const QString branch = m_ui->localBranchComboBox->currentText(); m_ui->infoLabel->setText(tr("Number of commits between %1 and %2: %3") .arg(branch)