forked from qt-creator/qt-creator
Translations: Remove header includes of *tr.h in .h files
The wrong Tr::tr could be executed by code indirectly including a *tr.h file from another module. To Translate in a header file, use QCoreApplication::tr(). Change-Id: I30e67245991d2c2f0eeb01ab356555bdb9841af0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
@@ -7,6 +7,7 @@
|
||||
#include "ctfstatisticsmodel.h"
|
||||
#include "ctfstatisticsview.h"
|
||||
#include "ctftimelinemodel.h"
|
||||
#include "ctfvisualizertr.h"
|
||||
#include "ctfvisualizertraceview.h"
|
||||
|
||||
#include <coreplugin/actionmanager/actioncontainer.h>
|
||||
|
||||
@@ -4,12 +4,12 @@
|
||||
#pragma once
|
||||
|
||||
#include "ctfvisualizerconstants.h"
|
||||
#include "ctfvisualizertr.h"
|
||||
|
||||
#include <debugger/debuggermainwindow.h>
|
||||
#include <tracing/timelinemodelaggregator.h>
|
||||
#include <tracing/timelinezoomcontrol.h>
|
||||
|
||||
#include <QCoreApplication>
|
||||
#include <QScopedPointer>
|
||||
|
||||
namespace CtfVisualizer {
|
||||
@@ -46,7 +46,8 @@ private:
|
||||
void toggleThreadRestriction(QAction *action);
|
||||
|
||||
Utils::Perspective m_perspective{Constants::CtfVisualizerPerspectiveId,
|
||||
::CtfVisualizer::Tr::tr("Chrome Trace Format Visualizer")};
|
||||
QCoreApplication::tr("::CtfVisualizer",
|
||||
"Chrome Trace Format Visualizer")};
|
||||
|
||||
bool m_isLoading;
|
||||
QScopedPointer<QAction> m_loadJson;
|
||||
|
||||
Reference in New Issue
Block a user