Translations: Remove header includes of *tr.h in .h files

The wrong Tr::tr could be executed by code indirectly including a *tr.h
file from another module.
To Translate in a header file, use QCoreApplication::tr().

Change-Id: I30e67245991d2c2f0eeb01ab356555bdb9841af0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Alessandro Portale
2023-02-08 11:15:14 +01:00
parent ccbee9bf42
commit 48affa1889
17 changed files with 45 additions and 31 deletions

View File

@@ -5,6 +5,7 @@
#include "gerritparameters.h"
#include "gerritserver.h"
#include "../gitclient.h"
#include "../gittr.h"
#include <coreplugin/icore.h>
@@ -281,8 +282,8 @@ bool GerritServer::resolveRoot()
case CertificateError:
if (QMessageBox::question(
Core::ICore::dialogParent(),
Tr::tr("Certificate Error"),
Tr::tr(
::Git::Tr::tr("Certificate Error"),
::Git::Tr::tr(
"Server certificate for %1 cannot be authenticated.\n"
"Do you want to disable SSL verification for this server?\n"
"Note: This can expose you to man-in-the-middle attack.")