feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Decorate some classes and methods with final keyword

Browse Source 
This way we silence the clang warnings about calling
virtual methods from c'tor or from d'tor:
[clang-analyzer-optin.cplusplus.VirtualCall]

Change-Id: I8d6318b490152133da4833bda2ba28622bce30dd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2020-11-18 17:04:54 +01:00
parent b2a766a79a
commit 48c2afe157
28 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/mesonprojectmanager/mesoninfoparser/buildoptions.h
View File

@@ -145,7 +145,7 @@ protected:
QString m_currentValue;
};
struct FeatureBuildOption : BuildOption
struct FeatureBuildOption final : BuildOption
{
QVariant value() const override { return QVariant::fromValue(m_currentValue); }
QString valueStr() const override { return m_currentValue.value(); }
@@ -225,7 +225,7 @@ protected:
QStringList m_currentValue;
};
struct BooleanBuildOption : BuildOption
struct BooleanBuildOption final : BuildOption
{
QVariant value() const override { return m_currentValue; }
QString valueStr() const override