Decorate some classes and methods with final keyword

This way we silence the clang warnings about calling
virtual methods from c'tor or from d'tor:
[clang-analyzer-optin.cplusplus.VirtualCall]

Change-Id: I8d6318b490152133da4833bda2ba28622bce30dd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/libs/advanceddockingsystem/workspacemodel.h

@@ -44,7 +44,7 @@ namespace ADS {
 class DockManager;
 class WorkspaceNameInputDialog;
 
-class WorkspaceModel : public QAbstractTableModel
+class WorkspaceModel final : public QAbstractTableModel
 {
     Q_OBJECT
 

src/libs/utils/flowlayout.h

@@ -32,7 +32,7 @@
 
 namespace Utils {
 
-class QTCREATOR_UTILS_EXPORT FlowLayout : public QLayout
+class QTCREATOR_UTILS_EXPORT FlowLayout final : public QLayout
 {
 public:
     explicit FlowLayout(QWidget *parent, int margin = -1, int hSpacing = -1, int vSpacing = -1);

src/libs/utils/progressindicator.h

@@ -53,7 +53,7 @@ public:
     ProgressIndicatorPainter(ProgressIndicatorSize size);
     virtual ~ProgressIndicatorPainter() = default;
 
-    virtual void setIndicatorSize(ProgressIndicatorSize size);
+    void setIndicatorSize(ProgressIndicatorSize size);
     ProgressIndicatorSize indicatorSize() const;
 
     void setUpdateCallback(const UpdateCallback &cb);

src/plugins/android/androidruncontrol.h

@@ -34,7 +34,7 @@ namespace Internal {
 
 class AndroidRunner;
 
-class AndroidRunSupport : public AndroidRunner
+class AndroidRunSupport final : public AndroidRunner
 {
     Q_OBJECT
 

src/plugins/clangcodemodel/clanghoverhandler.h

@@ -32,7 +32,7 @@
 namespace ClangCodeModel {
 namespace Internal {
 
-class ClangHoverHandler : public TextEditor::BaseHoverHandler
+class ClangHoverHandler final : public TextEditor::BaseHoverHandler
 {
     Q_DECLARE_TR_FUNCTIONS(ClangHoverHandler)
 

src/plugins/cmakeprojectmanager/cmakekitinformation.cpp

@@ -74,7 +74,7 @@ static Utils::Id defaultCMakeToolId()
 
 static const char TOOL_ID[] = "CMakeProjectManager.CMakeKitInformation";
 
-class CMakeKitAspectWidget : public KitAspectWidget
+class CMakeKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(CMakeProjectManager::Internal::CMakeKitAspect)
 public:
@@ -316,7 +316,7 @@ static const char EXTRA_GENERATOR_KEY[] = "ExtraGenerator";
 static const char PLATFORM_KEY[] = "Platform";
 static const char TOOLSET_KEY[] = "Toolset";
 
-class CMakeGeneratorKitAspectWidget : public KitAspectWidget
+class CMakeGeneratorKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(CMakeProjectManager::Internal::CMakeGeneratorKitAspect)
 public:
@@ -822,7 +822,7 @@ static const char CMAKE_CXX_TOOLCHAIN_KEY[] = "CMAKE_CXX_COMPILER";
 static const char CMAKE_QMAKE_KEY[] = "QT_QMAKE_EXECUTABLE";
 static const char CMAKE_PREFIX_PATH_KEY[] = "CMAKE_PREFIX_PATH";
 
-class CMakeConfigurationKitAspectWidget : public KitAspectWidget
+class CMakeConfigurationKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(CMakeProjectManager::Internal::CMakeConfigurationKitAspect)
 public:

src/plugins/coreplugin/locator/basefilefilter.h

@@ -49,7 +49,7 @@ public:
         virtual Utils::FilePath filePath() const = 0;
     };
 
-    class CORE_EXPORT ListIterator : public Iterator {
+    class CORE_EXPORT ListIterator final : public Iterator {
     public:
         ListIterator(const Utils::FilePaths &filePaths);
 

src/plugins/cpptools/cppincludesfilter.cpp

@@ -43,7 +43,7 @@ using namespace Utils;
 namespace CppTools {
 namespace Internal {
 
-class CppIncludesIterator : public BaseFileFilter::Iterator
+class CppIncludesIterator final : public BaseFileFilter::Iterator
 {
 public:
     CppIncludesIterator(CPlusPlus::Snapshot snapshot, const QSet<QString> &seedPaths);

src/plugins/debugger/console/console.h

@@ -48,7 +48,7 @@ using ScriptEvaluator = std::function<void (QString)>;
 class ConsoleItemModel;
 class ConsoleView;
 
-class Console : public Core::IOutputPane
+class Console final : public Core::IOutputPane
 {
     Q_OBJECT
 

src/plugins/debugger/debuggerkitinformation.cpp

@@ -55,7 +55,7 @@ namespace Debugger {
 
 namespace Internal {
 
-class DebuggerKitAspectWidget : public KitAspectWidget
+class DebuggerKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(Debugger::DebuggerKitAspect)
 

src/plugins/diffeditor/unifieddiffeditorwidget.h

@@ -45,7 +45,7 @@ namespace Internal {
 
 class DiffEditorDocument;
 
-class UnifiedDiffEditorWidget : public SelectableTextEditorWidget
+class UnifiedDiffEditorWidget final : public SelectableTextEditorWidget
 {
     Q_OBJECT
 public:

src/plugins/ios/iostoolhandler.cpp

@@ -218,7 +218,7 @@ protected:
     IosDeviceType m_devType;
 };
 
-class IosDeviceToolHandlerPrivate : public IosToolHandlerPrivate
+class IosDeviceToolHandlerPrivate final : public IosToolHandlerPrivate
 {
     enum State {
         NonStarted,

src/plugins/languageclient/languageclientcompletionassist.cpp

@@ -271,7 +271,7 @@ public:
 };
 
 
-class LanguageClientCompletionAssistProcessor : public IAssistProcessor
+class LanguageClientCompletionAssistProcessor final : public IAssistProcessor
 {
 public:
     LanguageClientCompletionAssistProcessor(Client *client);

src/plugins/languageclient/languageclienthoverhandler.h

@@ -32,7 +32,7 @@ namespace LanguageClient {
 
 class Client;
 
-class HoverHandler : public TextEditor::BaseHoverHandler
+class HoverHandler final : public TextEditor::BaseHoverHandler
 {
     Q_DECLARE_TR_FUNCTIONS(HoverHandler)
 public:

src/plugins/mesonprojectmanager/mesoninfoparser/buildoptions.h

@@ -145,7 +145,7 @@ protected:
     QString m_currentValue;
 };
 
-struct FeatureBuildOption : BuildOption
+struct FeatureBuildOption final : BuildOption
 {
     QVariant value() const override { return QVariant::fromValue(m_currentValue); }
     QString valueStr() const override { return m_currentValue.value(); }
@@ -225,7 +225,7 @@ protected:
     QStringList m_currentValue;
 };
 
-struct BooleanBuildOption : BuildOption
+struct BooleanBuildOption final : BuildOption
 {
     QVariant value() const override { return m_currentValue; }
     QString valueStr() const override

src/plugins/projectexplorer/compileoutputwindow.h

@@ -47,7 +47,7 @@ namespace Internal {
 class ShowOutputTaskHandler;
 class CompileOutputTextEdit;
 
-class CompileOutputWindow : public Core::IOutputPane
+class CompileOutputWindow final : public Core::IOutputPane
 {
     Q_OBJECT
 

src/plugins/projectexplorer/kitinformation.cpp

@@ -205,7 +205,7 @@ void SysRootKitAspect::setSysRoot(Kit *k, const Utils::FilePath &v)
 // --------------------------------------------------------------------------
 
 namespace Internal {
-class ToolChainKitAspectWidget : public KitAspectWidget
+class ToolChainKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(ProjectExplorer::ToolChainKitAspect)
 
@@ -693,7 +693,7 @@ void ToolChainKitAspect::toolChainRemoved(ToolChain *tc)
 // DeviceTypeKitAspect:
 // --------------------------------------------------------------------------
 namespace Internal {
-class DeviceTypeKitAspectWidget : public KitAspectWidget
+class DeviceTypeKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(ProjectExplorer::DeviceTypeKitAspect)
 
@@ -811,7 +811,7 @@ QSet<Utils::Id> DeviceTypeKitAspect::availableFeatures(const Kit *k) const
 // DeviceKitAspect:
 // --------------------------------------------------------------------------
 namespace Internal {
-class DeviceKitAspectWidget : public KitAspectWidget
+class DeviceKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(ProjectExplorer::DeviceKitAspect)
 
@@ -1062,7 +1062,7 @@ void DeviceKitAspect::devicesChanged()
 // EnvironmentKitAspect:
 // --------------------------------------------------------------------------
 namespace Internal {
-class EnvironmentKitAspectWidget : public KitAspectWidget
+class EnvironmentKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(ProjectExplorer::EnvironmentKitAspect)
 

src/plugins/projectexplorer/taskwindow.h

@@ -43,7 +43,7 @@ namespace Internal {
 class TaskWindowPrivate;
 
 // Show issues (warnings or errors) and open the editor on click.
-class TaskWindow : public Core::IOutputPane
+class TaskWindow final : public Core::IOutputPane
 {
     Q_OBJECT
 

src/plugins/qbsprojectmanager/qbsbuildstep.h

@@ -39,7 +39,7 @@ class QbsSession;
 
 class QbsBuildStepConfigWidget;
 
-class QbsBuildStep : public ProjectExplorer::BuildStep
+class QbsBuildStep final : public ProjectExplorer::BuildStep
 {
     Q_OBJECT
 

src/plugins/qbsprojectmanager/qbscleanstep.h

@@ -38,7 +38,7 @@ namespace Internal {
 class ErrorInfo;
 class QbsSession;
 
-class QbsCleanStep : public ProjectExplorer::BuildStep
+class QbsCleanStep final : public ProjectExplorer::BuildStep
 {
     Q_OBJECT
 

src/plugins/qbsprojectmanager/qbsinstallstep.h

@@ -39,7 +39,7 @@ namespace Internal {
 class ErrorInfo;
 class QbsSession;
 
-class QbsInstallStep : public ProjectExplorer::BuildStep
+class QbsInstallStep final : public ProjectExplorer::BuildStep
 {
     Q_OBJECT
 

src/plugins/qmakeprojectmanager/qmakekitinformation.cpp

@@ -45,7 +45,7 @@ using namespace Utils;
 namespace QmakeProjectManager {
 namespace Internal {
 
-class QmakeKitAspectWidget : public KitAspectWidget
+class QmakeKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(QmakeProjectManager::Internal::QmakeKitAspect)
 

src/plugins/qmldesigner/components/componentcore/abstractaction.h

@@ -56,7 +56,7 @@ public:
     AbstractAction(const QString &description = QString());
     AbstractAction(DefaultAction *action);
 
-    QAction *action() const override;
+    QAction *action() const override final;
     DefaultAction *defaultAction() const;
 
     void currentContextChanged(const SelectionContext &selectionContext) override;

src/plugins/qtsupport/qtkitinformation.cpp

@@ -49,7 +49,7 @@ using namespace Utils;
 namespace QtSupport {
 namespace Internal {
 
-class QtKitAspectWidget : public KitAspectWidget
+class QtKitAspectWidget final : public KitAspectWidget
 {
     Q_DECLARE_TR_FUNCTIONS(QtSupport::QtKitAspectWidget)
 public:

src/plugins/scxmleditor/plugin_interface/parallelitem.h

@@ -34,7 +34,7 @@ namespace PluginInterface {
 /**
  * @brief The ParalllelItem class represents Parallel-state of the SCXML-standard. It is a extended class from the StateItem.
  */
-class ParallelItem : public StateItem
+class ParallelItem final : public StateItem
 {
 public:
     explicit ParallelItem(const QPointF &pos = QPointF(), BaseItem *parent = nullptr);

src/plugins/scxmleditor/plugin_interface/scshapeprovider.h

@@ -35,7 +35,7 @@ namespace PluginInterface {
 
 class ScxmlTag;
 
-class SCShapeProvider : public ShapeProvider
+class SCShapeProvider final : public ShapeProvider
 {
     Q_OBJECT
 public:

src/plugins/texteditor/findincurrentfile.h

@@ -37,7 +37,7 @@ class IDocument;
 namespace TextEditor {
 namespace Internal {
 
-class FindInCurrentFile : public BaseFileFind
+class FindInCurrentFile final : public BaseFileFind
 {
     Q_OBJECT
 

src/plugins/updateinfo/updateinfoplugin.h

@@ -37,7 +37,7 @@ namespace Internal {
 
 class UpdateInfoPluginPrivate;
 
-class UpdateInfoPlugin : public ExtensionSystem::IPlugin
+class UpdateInfoPlugin final : public ExtensionSystem::IPlugin
 {
     Q_OBJECT
     Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "UpdateInfo.json")