feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Rename VcsBasePluginPrivate to VersionControlBase

Browse Source 
The classes derived from this had a dual role of implementing the
version control interface (IVersionControl) and as the plugin pimpls.
The name was focusing on the latter, but plugin pimpls are being phased
out in the new 'setupFoo()' world, so only the version control interface
part remains.

Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2024-02-06 16:05:34 +01:00
parent cf50a2d230
commit 48d47faa4b
16 changed files with 65 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/perforce/perforceplugin.cpp
View File

@@ -181,7 +181,7 @@ struct PerforceDiffParameters
QStringList files;
};
class PerforcePluginPrivate final : public VcsBasePluginPrivate
class PerforcePluginPrivate final : public VersionControlBase
{
public:
PerforcePluginPrivate();
@@ -361,7 +361,7 @@ public:
static PerforcePluginPrivate *dd = nullptr;
PerforcePluginPrivate::PerforcePluginPrivate()
: VcsBasePluginPrivate(Context(PERFORCE_CONTEXT))
: VersionControlBase(Context(PERFORCE_CONTEXT))
{
Context context(PERFORCE_CONTEXT);
@@ -912,7 +912,7 @@ void PerforcePluginPrivate::changelists(const FilePath &workingDir, const QStrin
}
}
void PerforcePluginPrivate::updateActions(VcsBasePluginPrivate::ActionState as)
void PerforcePluginPrivate::updateActions(VersionControlBase::ActionState as)
{
const bool menuActionEnabled = enableMenuAction(as, m_menuAction);
const bool enableActions = currentState().hasTopLevel() && menuActionEnabled;