feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SdkTool: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: I231597f60c7ddad00f7166e7d09c1c5b2ff48657
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Artem Sokolovskii
2022-05-25 15:46:50 +02:00
parent ea47190ed6
commit 48e2f79e8b
11 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/tools/sdktool/addtoolchainoperation.cpp
View File

@@ -308,12 +308,12 @@ QVariantMap AddToolChainData::addToolChain(const QVariantMap &map) const
data << KeyValuePair({tc, PATH}, Utils::FilePath::fromUserInput(m_path).toVariant());
data << KeyValuePair({tc, TARGET_ABI}, QVariant(m_targetAbi));
QVariantList abis;
QStringList abiStrings = m_supportedAbis.split(',');
foreach (const QString &s, abiStrings)
const QStringList abiStrings = m_supportedAbis.split(',');
for (const QString &s : abiStrings)
abis << QVariant(s);
data << KeyValuePair({tc, SUPPORTED_ABIS}, QVariant(abis));
KeyValuePairList tcExtraList;
foreach (const KeyValuePair &pair, m_extra)
for (const KeyValuePair &pair : qAsConst(m_extra))
tcExtraList << KeyValuePair(QStringList({tc}) << pair.key, pair.value);
data.append(tcExtraList);
data << KeyValuePair(COUNT, QVariant(count + 1));
@@ -335,7 +335,7 @@ bool AddToolChainData::exists(const QVariantMap &map, const QString &id)
// support old settings using QByteArray for id's
valueKeys.append(FindValueOperation::findValue(map, id.toUtf8()));
foreach (const QString &k, valueKeys) {
for (const QString &k : qAsConst(valueKeys)) {
if (k.endsWith(QString('/') + ID)) {
return true;
}