diff --git a/src/app/qtcreator.icns b/src/app/qtcreator.icns index 9d309e683e8..25241e22644 100644 Binary files a/src/app/qtcreator.icns and b/src/app/qtcreator.icns differ diff --git a/src/plugins/debugger/outputcollector.cpp b/src/plugins/debugger/outputcollector.cpp index 205ee91581b..d97f28ff0d9 100644 --- a/src/plugins/debugger/outputcollector.cpp +++ b/src/plugins/debugger/outputcollector.cpp @@ -80,7 +80,7 @@ bool OutputCollector::listen() return m_server->isListening(); m_server = new QLocalServer(this); connect(m_server, SIGNAL(newConnection()), SLOT(newConnectionAvailable())); - return m_server->listen(QLatin1String("creator-%1").arg(QCoreApplication::applicationPid())); // XXX how to make that secure? + return m_server->listen(QString::fromLatin1("creator-%1").arg(QCoreApplication::applicationPid())); // XXX how to make that secure? #else if (!m_serverPath.isEmpty()) return true; diff --git a/src/shared/proparser/profileevaluator.cpp b/src/shared/proparser/profileevaluator.cpp index c54b75a1e2d..8795b97d5b7 100644 --- a/src/shared/proparser/profileevaluator.cpp +++ b/src/shared/proparser/profileevaluator.cpp @@ -768,11 +768,15 @@ bool ProFileEvaluator::Private::visitProValue(ProValue *value) case ProVariable::RemoveOperator: // -= if (!m_cumulative) { if (!m_skipLevel) { - removeEach(&m_valuemap, varName, v); - removeEach(&m_filevaluemap[currentProFile()], varName, v); + // the insertUnique is a hack for the moment to fix the + // CONFIG -= app_bundle problem on Mac (add it to a variable -CONFIG as was done before) + if (removeEach(&m_valuemap, varName, v) == 0) + insertUnique(&m_valuemap, QString("-%1").arg(varName), v); + if (removeEach(&m_filevaluemap[currentProFile()], varName, v) == 0) + insertUnique(&m_filevaluemap[currentProFile()], QString("-%1").arg(varName), v); } } else if (!m_skipLevel) { - // this is a hack for the moment to fix the + // the insertUnique is a hack for the moment to fix the // CONFIG -= app_bundle problem on Mac (add it to a variable -CONFIG as was done before) insertUnique(&m_valuemap, QString("-%1").arg(varName), v); insertUnique(&m_filevaluemap[currentProFile()], QString("-%1").arg(varName), v); diff --git a/src/shared/proparser/proparserutils.h b/src/shared/proparser/proparserutils.h index 7c751c9c273..41c62c88191 100644 --- a/src/shared/proparser/proparserutils.h +++ b/src/shared/proparser/proparserutils.h @@ -140,12 +140,14 @@ static void insertUnique(QHash *map, sl.append(str); } -static void removeEach(QHash *map, +static int removeEach(QHash *map, const QString &key, const QStringList &value) { + int count = 0; QStringList &sl = (*map)[key]; foreach (const QString &str, value) - sl.removeAll(str); + count += sl.removeAll(str); + return count; } /*