From 4947c5c6573584eeec6bbbd01080950f913188d3 Mon Sep 17 00:00:00 2001 From: Artem Sokolovskii Date: Mon, 2 Jan 2023 12:56:03 +0100 Subject: [PATCH] qmljs: Fix warnings Change-Id: I4bac76e9d7286fc762af3b097102b3aa975f7247 Reviewed-by: Reviewed-by: Jarek Kobus --- src/libs/qmljs/persistenttrie.h | 2 +- src/libs/qmljs/qmljsimportdependencies.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libs/qmljs/persistenttrie.h b/src/libs/qmljs/persistenttrie.h index 59d376f6025..a8bc62144c1 100644 --- a/src/libs/qmljs/persistenttrie.h +++ b/src/libs/qmljs/persistenttrie.h @@ -88,7 +88,7 @@ template void enumerateTrieNode(const TrieNode::Ptr &trie, T &t, if (trie.isNull()) return; base.append(trie->prefix); - for (const TrieNode::Ptr subT : std::as_const(trie->postfixes)) { + for (const TrieNode::Ptr &subT : std::as_const(trie->postfixes)) { enumerateTrieNode(subT,t,base); } if (trie->postfixes.isEmpty()) diff --git a/src/libs/qmljs/qmljsimportdependencies.cpp b/src/libs/qmljs/qmljsimportdependencies.cpp index 92cdb261391..39bee11a2a7 100644 --- a/src/libs/qmljs/qmljsimportdependencies.cpp +++ b/src/libs/qmljs/qmljsimportdependencies.cpp @@ -663,7 +663,7 @@ void ImportDependencies::iterateOnCandidateImports( for (const QString &cImportName : imp) { CoreImport cImport = coreImport(cImportName); if (languageIsCompatible(vContext.language, cImport.language)) { - for (const Export e : std::as_const(cImport.possibleExports)) { + for (const Export &e : std::as_const(cImport.possibleExports)) { ++benchMark.nPossibleExports; if (e.visibleInVContext(vContext)) { ImportMatchStrength m = e.exportName.matchImport(key, vContext); @@ -686,7 +686,7 @@ void ImportDependencies::iterateOnCandidateImports( for (const QString &cImportName : std::as_const(lb.value())) { CoreImport cImport = coreImport(cImportName); if (languageIsCompatible(vContext.language, cImport.language)) { - for (const Export e : std::as_const(cImport.possibleExports)) { + for (const Export &e : std::as_const(cImport.possibleExports)) { ++benchMark.nPossibleExports; if (e.visibleInVContext(vContext)) { ImportMatchStrength m = e.exportName.matchImport(key, vContext);