From 49626f7ea9085d167ea822b5fda6170e3949a1fc Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 23 Apr 2020 09:07:52 +0200 Subject: [PATCH] CMake build: Fix devel package issues Include paths and headers were missing for building a separator Qt Quick Designer plugin. Task-number: QTCREATORBUG-23778 Change-Id: Ib6ba96ad42a8b2b36e0ee2f0e3c51c27f3365d37 Reviewed-by: Cristian Adam --- cmake/QtCreatorAPI.cmake | 6 +++++- src/libs/qmljs/CMakeLists.txt | 1 + src/plugins/qmldesigner/CMakeLists.txt | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/cmake/QtCreatorAPI.cmake b/cmake/QtCreatorAPI.cmake index 82f7897b6d5..993102e139a 100644 --- a/cmake/QtCreatorAPI.cmake +++ b/cmake/QtCreatorAPI.cmake @@ -229,7 +229,11 @@ function(set_public_includes target includes) if (NOT IS_ABSOLUTE ${inc_dir}) set(inc_dir "${CMAKE_CURRENT_SOURCE_DIR}/${inc_dir}") endif() - target_include_directories(${target} PUBLIC $) + file(RELATIVE_PATH include_dir_relative_path ${PROJECT_SOURCE_DIR} ${inc_dir}) + target_include_directories(${target} PUBLIC + $ + $ + ) endforeach() endfunction() diff --git a/src/libs/qmljs/CMakeLists.txt b/src/libs/qmljs/CMakeLists.txt index 2c05b662c3b..243966afdad 100644 --- a/src/libs/qmljs/CMakeLists.txt +++ b/src/libs/qmljs/CMakeLists.txt @@ -7,6 +7,7 @@ add_qtc_library(QmlJS parser/qmljsast.cpp parser/qmljsast_p.h parser/qmljsastfwd_p.h parser/qmljsastvisitor.cpp parser/qmljsastvisitor_p.h + parser/qmljsdiagnosticmessage_p.h parser/qmljsengine_p.cpp parser/qmljsengine_p.h parser/qmljsglobal_p.h parser/qmljsgrammar.cpp parser/qmljsgrammar_p.h diff --git a/src/plugins/qmldesigner/CMakeLists.txt b/src/plugins/qmldesigner/CMakeLists.txt index 42feb7c13f7..75a8571b818 100644 --- a/src/plugins/qmldesigner/CMakeLists.txt +++ b/src/plugins/qmldesigner/CMakeLists.txt @@ -144,6 +144,7 @@ extend_qtc_plugin(QmlDesigner extend_qtc_plugin(QmlDesigner SOURCES_PREFIX ../../../share/qtcreator/qml/qmlpuppet/interfaces + PUBLIC_INCLUDES ../../../share/qtcreator/qml/qmlpuppet/interfaces SOURCES nodeinstanceserverinterface.cpp commondefines.h @@ -202,6 +203,7 @@ extend_qtc_plugin(QmlDesigner extend_qtc_plugin(QmlDesigner SOURCES_PREFIX components/formeditor + PUBLIC_INCLUDES components/formeditor SOURCES abstractcustomtool.cpp abstractcustomtool.h abstractformeditortool.cpp abstractformeditortool.h @@ -257,6 +259,7 @@ extend_qtc_plugin(QmlDesigner extend_qtc_plugin(QmlDesigner SOURCES_PREFIX components/integration + PUBLIC_INCLUDES components/integration SOURCES componentaction.cpp componentaction.h componentview.cpp componentview.h @@ -470,6 +473,7 @@ extend_qtc_plugin(QmlDesigner extend_qtc_plugin(QmlDesigner SOURCES_PREFIX designercore + PUBLIC_INCLUDES designercore SOURCES metainfo/itemlibraryinfo.cpp metainfo/metainfo.cpp