diff --git a/src/plugins/python/pysidebuildconfiguration.cpp b/src/plugins/python/pysidebuildconfiguration.cpp index eae9b4eeeae..3285493e0a3 100644 --- a/src/plugins/python/pysidebuildconfiguration.cpp +++ b/src/plugins/python/pysidebuildconfiguration.cpp @@ -23,20 +23,6 @@ namespace Python::Internal { const char pySideBuildStep[] = "Python.PysideBuildStep"; -PySideBuildConfigurationFactory::PySideBuildConfigurationFactory() -{ - registerBuildConfiguration("Python.PySideBuildConfiguration"); - setSupportedProjectType(PythonProjectId); - setSupportedProjectMimeTypeName(Constants::C_PY_MIMETYPE); - setBuildGenerator([](const Kit *, const FilePath &projectPath, bool) { - BuildInfo info; - info.displayName = "build"; - info.typeName = "build"; - info.buildDirectory = projectPath.parentDir(); - return QList{info}; - }); -} - PySideBuildStepFactory::PySideBuildStepFactory() { registerStep(pySideBuildStep); @@ -83,17 +69,38 @@ void PySideBuildStep::doRun() emit finished(true); } -PySideBuildConfiguration::PySideBuildConfiguration(Target *target, Id id) - : BuildConfiguration(target, id) + +// PySideBuildConfiguration + +class PySideBuildConfiguration : public BuildConfiguration { - setConfigWidgetDisplayName(Tr::tr("General")); +public: + PySideBuildConfiguration(Target *target, Id id) + : BuildConfiguration(target, id) + { + setConfigWidgetDisplayName(Tr::tr("General")); + + setInitializer([this](const BuildInfo &) { + buildSteps()->appendStep(pySideBuildStep); + updateCacheAndEmitEnvironmentChanged(); + }); - setInitializer([this](const BuildInfo &) { - buildSteps()->appendStep(pySideBuildStep); updateCacheAndEmitEnvironmentChanged(); - }); + } +}; - updateCacheAndEmitEnvironmentChanged(); +PySideBuildConfigurationFactory::PySideBuildConfigurationFactory() +{ + registerBuildConfiguration("Python.PySideBuildConfiguration"); + setSupportedProjectType(PythonProjectId); + setSupportedProjectMimeTypeName(Constants::C_PY_MIMETYPE); + setBuildGenerator([](const Kit *, const FilePath &projectPath, bool) { + BuildInfo info; + info.displayName = "build"; + info.typeName = "build"; + info.buildDirectory = projectPath.parentDir(); + return QList{info}; + }); } } // Python::Internal diff --git a/src/plugins/python/pysidebuildconfiguration.h b/src/plugins/python/pysidebuildconfiguration.h index 17022c6be2b..8a04568d70a 100644 --- a/src/plugins/python/pysidebuildconfiguration.h +++ b/src/plugins/python/pysidebuildconfiguration.h @@ -9,18 +9,6 @@ namespace Python::Internal { -class PySideBuildConfiguration : public ProjectExplorer::BuildConfiguration -{ -public: - PySideBuildConfiguration(ProjectExplorer::Target *target, Utils::Id id); -}; - -class PySideBuildConfigurationFactory : public ProjectExplorer::BuildConfigurationFactory -{ -public: - PySideBuildConfigurationFactory(); -}; - class PySideBuildStep : public ProjectExplorer::AbstractProcessStep { Q_OBJECT @@ -41,4 +29,10 @@ public: PySideBuildStepFactory(); }; +class PySideBuildConfigurationFactory : public ProjectExplorer::BuildConfigurationFactory +{ +public: + PySideBuildConfigurationFactory(); +}; + } // Python::Internal