From 49e7f075260a3387a84a89e36c6197cd4c736209 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Tue, 4 Apr 2017 12:02:39 +0200 Subject: [PATCH] QmlDesigner: Fix crash I found the crash when opening: qtquickcontrols2\examples\quickcontrols2\contactlist\ContactForm.ui.qml. The crash was triggered by the root item being a layout. Change-Id: Id95aee6c76fbe1102578fb5a297b155645ebb157 Reviewed-by: Tim Jenssen --- src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp index f1665484b32..a5ff1215845 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp @@ -371,6 +371,9 @@ bool itemIsMovable(const ModelNode &modelNode) if (modelNode.metaInfo().isSubclassOf("QtQuick.Controls.Tab")) return false; + if (!modelNode.hasParentProperty()) + return false; + if (!modelNode.parentProperty().isNodeListProperty()) return false;