feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClassView: Optimize operator== of internal data

Browse Source 
Make all of the fields of SymbolLocation and SymbolInformation
const members. Optimize a bit operator== of these structures:
check first if hashes are non-equal - in this case return
false early. Fix hash type of SymbolInformation for porting
to Qt6 purpose.

Task-number: QTCREATORBUG-25317
Task-number: QTCREATORBUG-24098
Change-Id: I769f99ff3157093e9f10ee3929bc7f6eb83f34e3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2021-02-16 01:37:49 +01:00
parent 06f305265b
commit 4a15f6d16b
6 changed files with 38 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/classview/classviewsymbollocation.cpp
View File

@@ -45,20 +45,16 @@ SymbolLocation::SymbolLocation() :
{
}
SymbolLocation::SymbolLocation(QString file, int lineNumber, int columnNumber) :
m_fileName(file),
m_line(lineNumber),
m_column(columnNumber)
{
if (m_column < 0)
m_column = 0;
// pre-computate hash value
SymbolLocation::SymbolLocation(const QString &file, int lineNumber, int columnNumber)
: m_fileName(file)
, m_line(lineNumber)
, m_column(qMax(columnNumber, 0))
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
m_hash = qHashMulti(0, m_fileName, m_line, m_column);
, m_hash(qHashMulti(0, m_fileName, m_line, m_column))
#else
m_hash = qHash(qMakePair(m_fileName, qMakePair(m_line, m_column)));
, m_hash(qHash(qMakePair(m_fileName, qMakePair(m_line, m_column))))
#endif
{
}
} // namespace Internal