feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Fix coverity PASS_BY_VALUE warnings

Browse Source 
Coverity-Id: 1569153 Performance inefficiencies  (PASS_BY_VALUE)
Change-Id: I03663b09ac3cbbaf3dec87dc9389c2015c16fafd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Cristian Adam
2023-10-31 14:36:37 +01:00
parent 76a8f81ea7
commit 4a220ab20a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/fileapidataextractor.cpp
View File

@@ -388,7 +388,7 @@ static RawProjectParts generateRawProjectParts(const QFuture<void> &cancelFuture
// CMake users worked around Creator's inability of listing header files by creating // CMake users worked around Creator's inability of listing header files by creating
// custom targets with all the header files. This target breaks the code model, so // custom targets with all the header files. This target breaks the code model, so
// keep quiet about it:-) // keep quiet about it:-)
if (ci.defines.empty() && ci.includes.empty() && allOf(ci.sources, [t](const int sid) { if (ci.defines.empty() && ci.includes.empty() && allOf(ci.sources, [&t](const int sid) {
const SourceInfo &source = t.sources[static_cast<size_t>(sid)]; const SourceInfo &source = t.sources[static_cast<size_t>(sid)];
return Node::fileTypeForFileName(FilePath::fromString(source.path)) return Node::fileTypeForFileName(FilePath::fromString(source.path))
== FileType::Header; == FileType::Header;
@@ -431,7 +431,7 @@ static RawProjectParts generateRawProjectParts(const QFuture<void> &cancelFuture
} }
// Skip groups with only generated source files e.g. <build-dir>/.rcc/qrc_<target>.cpp // Skip groups with only generated source files e.g. <build-dir>/.rcc/qrc_<target>.cpp
if (allOf(ci.sources, [t](const auto &idx) { return t.sources.at(idx).isGenerated; })) if (allOf(ci.sources, [&t](const auto &idx) { return t.sources.at(idx).isGenerated; }))
continue; continue;
// If we are not in a pch compiler group, add all the headers that are not generated // If we are not in a pch compiler group, add all the headers that are not generated