feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Improve is valid check

Browse Source 
There are many keys and the check for an item is expensive. There will
be no form editor item in scene for non qml items. So there is no need
to check it.

Change-Id: I31888f7d9f3b487e6c8181c40d9126446e8288ad
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Marco Bubke
2025-05-24 14:55:14 +02:00
parent 034fb098bc
commit 4a697a6099
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/components/formeditor/formeditorview.cpp
View File

@@ -721,9 +721,10 @@ void FormEditorView::instanceInformationsChanged(const QMultiHash<ModelNode, Inf
{ {
QList<FormEditorItem *> changedItems; QList<FormEditorItem *> changedItems;
QList<ModelNode> informationChangedNodes = Utils::filtered( QList<ModelNode> informationChangedNodes = Utils::filtered(informationChangedHash.keys(),
informationChangedHash.keys(), [](const ModelNode &node) {
[](const ModelNode &node) { return QmlItemNode::isValidQmlItemNode(node); }); return node.isValid();
});
for (const ModelNode &node : informationChangedNodes) { for (const ModelNode &node : informationChangedNodes) {
const QmlItemNode qmlItemNode(node); const QmlItemNode qmlItemNode(node);