feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RemoteLinuxEnvironmentReader: Get rid of no-op call to QtcProcess::terminate()

Browse Source 
Calling QtcProcess::terminate() is a task for implicit ProcessReaper.
Delete the process later instead.

Change-Id: I0f4f531e7eefff2ca6ecec350fb3c95b97ba4c2c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2022-03-25 18:39:33 +01:00
parent de88d00ca4
commit 4a6d6d1323
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/remotelinux/remotelinuxenvironmentreader.cpp
View File

@@ -124,8 +124,6 @@ void RemoteLinuxEnvironmentReader::destroyProcess()
if (!m_deviceProcess) if (!m_deviceProcess)
return; return;
m_deviceProcess->disconnect(this); m_deviceProcess->disconnect(this);
if (m_deviceProcess->state() != QProcess::NotRunning)
m_deviceProcess->terminate();
m_deviceProcess->deleteLater(); m_deviceProcess->deleteLater();
m_deviceProcess = nullptr; m_deviceProcess = nullptr;
} }