From 4aab6a9173c03abe2217a191b1f98fba444e6781 Mon Sep 17 00:00:00 2001
From: Marcus Tillmanns <marcus.tillmanns@qt.io>
Date: Wed, 31 Jan 2024 11:11:18 +0100
Subject: [PATCH] LanguageClient: Don't needlessly store empty values

Task-number: QTCREATORBUG-24762
Change-Id: Ifdff1e3cd23ce287b0c7a17064587e995616d42f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
---
 src/plugins/languageclient/languageclientsettings.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/plugins/languageclient/languageclientsettings.cpp b/src/plugins/languageclient/languageclientsettings.cpp
index 6f222f01cb1..82d80f4c27c 100644
--- a/src/plugins/languageclient/languageclientsettings.cpp
+++ b/src/plugins/languageclient/languageclientsettings.cpp
@@ -664,8 +664,10 @@ void LanguageClientSettings::toSettings(QtcSettings *settings,
     auto isStdioSetting = Utils::equal(&BaseSettings::m_settingsTypeId,
                                        Utils::Id(Constants::LANGUAGECLIENT_STDIO_SETTINGS_ID));
     auto [stdioSettings, typedSettings] = Utils::partition(languageClientSettings, isStdioSetting);
-    settings->setValue(clientsKey, transform(stdioSettings));
-    settings->setValue(typedClientsKey, transform(typedSettings));
+    if (!stdioSettings.isEmpty())
+        settings->setValue(clientsKey, transform(stdioSettings));
+    if (!typedSettings.isEmpty())
+        settings->setValue(typedClientsKey, transform(typedSettings));
     settings->endGroup();
 }