From 4ae0ad3ab5cc8877cefa72b5eae559cbe8ccdc9f Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 30 Jan 2019 18:48:58 +0100 Subject: [PATCH] ProjectExplorer: Use a addSupportedTargetDeviceType function ... also for BuildConfigurationFactory, similar to Run and Deploy. Change-Id: I453f08bf145d6a2e764d150646c698d624ae2ce9 Reviewed-by: Eike Ziller --- src/plugins/ios/iosbuildconfiguration.cpp | 3 ++- src/plugins/projectexplorer/buildconfiguration.cpp | 4 ++-- src/plugins/projectexplorer/buildconfiguration.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/plugins/ios/iosbuildconfiguration.cpp b/src/plugins/ios/iosbuildconfiguration.cpp index a3b43d1183a..cf5298e7220 100644 --- a/src/plugins/ios/iosbuildconfiguration.cpp +++ b/src/plugins/ios/iosbuildconfiguration.cpp @@ -143,7 +143,8 @@ void IosBuildConfiguration::updateQmakeCommand() IosBuildConfigurationFactory::IosBuildConfigurationFactory() { registerBuildConfiguration(QmakeProjectManager::Constants::QMAKE_BC_ID); - setSupportedTargetDeviceTypes({Constants::IOS_DEVICE_TYPE, Constants::IOS_SIMULATOR_TYPE}); + addSupportedTargetDeviceType(Constants::IOS_DEVICE_TYPE); + addSupportedTargetDeviceType(Constants::IOS_SIMULATOR_TYPE); setBasePriority(1); } diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index 8828f36f644..9b29f628334 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -413,9 +413,9 @@ void BuildConfigurationFactory::setSupportedProjectMimeTypeName(const QString &m m_supportedProjectMimeTypeName = mimeTypeName; } -void BuildConfigurationFactory::setSupportedTargetDeviceTypes(const QList &ids) +void BuildConfigurationFactory::addSupportedTargetDeviceType(Core::Id id) { - m_supportedTargetDeviceTypes = ids; + m_supportedTargetDeviceTypes.append(id); } void BuildConfigurationFactory::setBasePriority(int basePriority) diff --git a/src/plugins/projectexplorer/buildconfiguration.h b/src/plugins/projectexplorer/buildconfiguration.h index f71e895a230..09abdaa5105 100644 --- a/src/plugins/projectexplorer/buildconfiguration.h +++ b/src/plugins/projectexplorer/buildconfiguration.h @@ -160,7 +160,7 @@ protected: bool supportsTargetDeviceType(Core::Id id) const; void setSupportedProjectType(Core::Id id); void setSupportedProjectMimeTypeName(const QString &mimeTypeName); - void setSupportedTargetDeviceTypes(const QList &ids); + void addSupportedTargetDeviceType(Core::Id id); void setDefaultDisplayName(const QString &defaultDisplayName); void setBasePriority(int basePriority);