From 4b0f31e823723e4c10d9eb261e3e0fb732a9e712 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Mon, 15 Apr 2024 15:03:19 +0200 Subject: [PATCH] QmlDesigner: Fix crash on shutdown We have to set the correct onwership. For objects from C++ QJSEngine::CppOwnership is the default, unless the object comes from a function like here. Change-Id: Idc35e2b06656da228a55d78e5b41f84795a8aa6e Reviewed-by: Miikka Heikkinen Reviewed-by: Tim Jenssen --- .../qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp b/src/plugins/qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp index 3daa6c4ecce..fc39b371375 100644 --- a/src/plugins/qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp +++ b/src/plugins/qmldesigner/components/propertyeditor/qmlmodelnodeproxy.cpp @@ -151,6 +151,8 @@ PropertyEditorSubSelectionWrapper *QmlModelNodeProxy::registerSubSelectionWrappe new PropertyEditorSubSelectionWrapper(node)); m_subselection.append(wrapper); + QJSEngine::setObjectOwnership(wrapper.data(), QJSEngine::CppOwnership); + return wrapper.data(); }