feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Fix some clazy level0 warnings

Browse Source 
Use QString instead of an empty QStringLiteral
  [-Wclazy-empty-qstringliteral]

Use the static QFileInfo::exists() instead. It's documented to be
  faster. [-Wclazy-qfileinfo-exists]

Unused CppTools::ClangDiagnosticConfigs
  [-Wclazy-unused-non-trivial-variable]

Change-Id: Ia4098d1191d6fcfc6e0774f71c39acdea3f0f36c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Nikolai Kosjar
2019-02-07 12:41:04 +01:00
parent ae388a85b9
commit 4b26a8c66e
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/clangcodemodel/clangbackendcommunicator.cpp
View File

@@ -63,9 +63,7 @@ enum { backEndStartTimeOutInMs = 10000 };
static QString backendProcessPath() static QString backendProcessPath()
{ {
return Core::ICore::libexecPath() return Core::ICore::libexecPath() + "/clangbackend" + QTC_HOST_EXE_SUFFIX;
+ QStringLiteral("/clangbackend")
+ QStringLiteral(QTC_HOST_EXE_SUFFIX);
} }
namespace ClangCodeModel { namespace ClangCodeModel {
@@ -121,7 +119,7 @@ BackendCommunicator::~BackendCommunicator()
void BackendCommunicator::initializeBackend() void BackendCommunicator::initializeBackend()
{ {
const QString clangBackEndProcessPath = backendProcessPath(); const QString clangBackEndProcessPath = backendProcessPath();
if (!QFileInfo(clangBackEndProcessPath).exists()) { if (!QFileInfo::exists(clangBackEndProcessPath)) {
logExecutableDoesNotExist(); logExecutableDoesNotExist();
return; return;
} }

1
src/plugins/clangcodemodel/clangtextmark.cpp
View File

@@ -133,7 +133,6 @@ void disableDiagnosticInCurrentProjectConfig(const ClangBackEnd::DiagnosticConta
currentConfigId = globalSettings->clangDiagnosticConfigId(); currentConfigId = globalSettings->clangDiagnosticConfigId();
// Get config // Get config
const ClangDiagnosticConfigs originalConfigs = globalSettings->clangCustomDiagnosticConfigs();
ClangDiagnosticConfigsModel configsModel(globalSettings->clangCustomDiagnosticConfigs()); ClangDiagnosticConfigsModel configsModel(globalSettings->clangCustomDiagnosticConfigs());
QTC_ASSERT(configsModel.hasConfigWithId(currentConfigId), return ); QTC_ASSERT(configsModel.hasConfigWithId(currentConfigId), return );
ClangDiagnosticConfig config = configsModel.configWithId(currentConfigId); ClangDiagnosticConfig config = configsModel.configWithId(currentConfigId);