feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Don't save the run worker in LocalQmlProfilerSupport

Browse Source 
We don't need it and will dangle when the RunControl drops its workers.

Change-Id: I93e872083a870ad860624509622c5d779e35dfd3
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ulf Hermann
2018-08-20 12:01:08 +02:00
parent 5b2ac16011
commit 4b57f6ac3d
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/qmlprofiler/qmlprofilerruncontrol.cpp
View File

@@ -231,15 +231,15 @@ LocalQmlProfilerSupport::LocalQmlProfilerSupport(QmlProfilerTool *profilerTool,
{ {
setDisplayName("LocalQmlProfilerSupport"); setDisplayName("LocalQmlProfilerSupport");
m_profiler = new QmlProfilerRunner(runControl); QmlProfilerRunner *profiler = new QmlProfilerRunner(runControl);
m_profiler->setServerUrl(serverUrl); profiler->setServerUrl(serverUrl);
connect(m_profiler, &QmlProfilerRunner::starting, connect(profiler, &QmlProfilerRunner::starting,
profilerTool, &QmlProfilerTool::finalizeRunControl); profilerTool, &QmlProfilerTool::finalizeRunControl);
addStopDependency(m_profiler); addStopDependency(profiler);
// We need to open the local server before the application tries to connect. // We need to open the local server before the application tries to connect.
// In the TCP case, it doesn't hurt either to start the profiler before. // In the TCP case, it doesn't hurt either to start the profiler before.
addStartDependency(m_profiler); addStartDependency(profiler);
Runnable debuggee = runnable(); Runnable debuggee = runnable();

3
src/plugins/qmlprofiler/qmlprofilerruncontrol.h
View File

@@ -75,9 +75,6 @@ public:
LocalQmlProfilerSupport(QmlProfilerTool *profilerTool, ProjectExplorer::RunControl *runControl); LocalQmlProfilerSupport(QmlProfilerTool *profilerTool, ProjectExplorer::RunControl *runControl);
LocalQmlProfilerSupport(QmlProfilerTool *profilerTool, ProjectExplorer::RunControl *runControl, LocalQmlProfilerSupport(QmlProfilerTool *profilerTool, ProjectExplorer::RunControl *runControl,
const QUrl &serverUrl); const QUrl &serverUrl);
private:
QmlProfilerRunner *m_profiler;
}; };
} // namespace Internal } // namespace Internal