Core: De-pure IOutputPane::visibilityChanged()

Most implementations are empty.

Change-Id: I811cacfc2918c8b2803798c4f5d3dabc7d60ccd1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>

src/plugins/autotest/testresultspane.cpp

@@ -343,10 +343,6 @@ void TestResultsPane::clearContents()
     clearMarks();
 }
 
-void TestResultsPane::visibilityChanged(bool /*visible*/)
-{
-}
-
 void TestResultsPane::setFocus()
 {
 }

src/plugins/autotest/testresultspane.h

@@ -85,7 +85,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     void setFocus() override;
     bool hasFocus() const override;
     bool canFocus() const override;

src/plugins/coreplugin/ioutputpane.h

@@ -58,7 +58,7 @@ public:
     virtual int priorityInStatusBar() const = 0;
 
     virtual void clearContents() = 0;
-    virtual void visibilityChanged(bool visible) = 0;
+    virtual void visibilityChanged(bool visible);
 
     virtual void setFocus() = 0;
     virtual bool hasFocus() const = 0;

src/plugins/coreplugin/messageoutputwindow.cpp

@@ -105,10 +105,6 @@ QString MessageOutputWindow::displayName() const
     return tr("General Messages");
 }
 
-void MessageOutputWindow::visibilityChanged(bool /*b*/)
-{
-}
-
 void MessageOutputWindow::append(const QString &text)
 {
     m_widget->appendMessage(text, Utils::DebugFormat);

src/plugins/coreplugin/messageoutputwindow.h

@@ -45,7 +45,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
 
     void append(const QString &text);
     bool canFocus() const override;

src/plugins/coreplugin/outputpanemanager.cpp

@@ -126,6 +126,10 @@ QList<QWidget *> IOutputPane::toolBarWidgets() const
     return widgets << m_zoomInButton << m_zoomOutButton;
 }
 
+void IOutputPane::visibilityChanged(bool /*visible*/)
+{
+}
+
 void IOutputPane::setFont(const QFont &font)
 {
     emit fontChanged(font);

src/plugins/debugger/console/console.cpp

@@ -175,10 +175,6 @@ void Console::clearContents()
     m_consoleItemModel->clear();
 }
 
-void Console::visibilityChanged(bool /*visible*/)
-{
-}
-
 bool Console::canFocus() const
 {
     return true;

src/plugins/debugger/console/console.h

@@ -61,7 +61,6 @@ public:
     QString displayName() const override { return tr("QML Debugger Console"); }
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;

src/plugins/projectexplorer/appoutputpane.cpp

@@ -341,10 +341,6 @@ void AppOutputPane::clearContents()
         currentWindow->clear();
 }
 
-void AppOutputPane::visibilityChanged(bool /* b */)
-{
-}
-
 bool AppOutputPane::hasFocus() const
 {
     QWidget *widget = m_tabWidget->currentWidget();

src/plugins/projectexplorer/appoutputpane.h

@@ -70,7 +70,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;

src/plugins/projectexplorer/compileoutputwindow.cpp

@@ -215,9 +215,6 @@ void CompileOutputWindow::clearContents()
     m_taskPositions.clear();
 }
 
-void CompileOutputWindow::visibilityChanged(bool)
-{ }
-
 int CompileOutputWindow::priorityInStatusBar() const
 {
     return 50;

src/plugins/projectexplorer/compileoutputwindow.h

@@ -60,7 +60,6 @@ public:
     QString displayName() const override { return tr("Compile Output"); }
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;

src/plugins/serialterminal/serialoutputpane.cpp

@@ -210,11 +210,6 @@ void SerialOutputPane::clearContents()
         currentWindow->clear();
 }
 
-void SerialOutputPane::visibilityChanged(bool)
-{
-    // Unused but pure virtual
-}
-
 bool SerialOutputPane::canFocus() const
 {
     return m_tabWidget->currentWidget();

src/plugins/serialterminal/serialoutputpane.h

@@ -76,7 +76,6 @@ public:
 
     int priorityInStatusBar() const final;
     void clearContents() final;
-    void visibilityChanged(bool) final;
     bool canFocus() const final;
     bool hasFocus() const final;
     void setFocus() final;

src/plugins/todo/todooutputpane.cpp

@@ -94,11 +94,6 @@ void TodoOutputPane::clearContents()
     clearKeywordFilter();
 }
 
-void TodoOutputPane::visibilityChanged(bool visible)
-{
-    Q_UNUSED(visible)
-}
-
 void TodoOutputPane::setFocus()
 {
     m_todoTreeView->setFocus();

src/plugins/todo/todooutputpane.h

@@ -60,7 +60,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     void setFocus() override;
     bool hasFocus() const override;
     bool canFocus() const override;