feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: calling QImage::constBits() instead of QImage::bits()

Browse Source 
the non-const QImage::bits() performs shared-data checks. With
QImage::constBits() we can skip those for sure in cases where we only
want to read.

Change-Id: Ic5f328b54eb2d9930ad31b4df8d9b636dc005982
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Alessandro Portale
2014-07-23 11:02:29 +02:00
committed by hjk
parent 18dca1e3ac
commit 4b76d50a11
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/coreplugin/styleanimator.cpp
View File

@@ -65,8 +65,8 @@ void Animation::drawBlendedImage(QPainter *painter, const QRect &rect, float alp
case 32:
{
uchar *mixed_data = m_tempImage.bits();
const uchar *back_data = m_primaryImage.bits();
const uchar *front_data = m_secondaryImage.bits();
const uchar *back_data = m_primaryImage.constBits();
const uchar *front_data = m_secondaryImage.constBits();
for (int sy = 0; sy < sh; sy++) {
quint32 *mixed = (quint32*)mixed_data;
const quint32* back = (const quint32*)back_data;