feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix QTC_ASSERT

Browse Source 
The ModelNode has to be always valid, but not the QmlItemNode.

Change-Id: I906f2f6ec101b5d19223a3b5103c81c76f2585fe
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Thomas Hartmann
2020-09-15 16:23:03 +02:00
parent 7e50cd4841
commit 4bcc371dfb
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmldesigner/components/propertyeditor/qmlanchorbindingproxy.cpp
View File

@@ -894,7 +894,11 @@ QmlItemNode QmlAnchorBindingProxy::targetIdToNode(const QString &id) const
QString QmlAnchorBindingProxy::idForNode(const QmlItemNode &qmlItemNode) const QString QmlAnchorBindingProxy::idForNode(const QmlItemNode &qmlItemNode) const
{ {
QTC_ASSERT(qmlItemNode.isValid(), return {}); QTC_ASSERT(qmlItemNode.modelNode().isValid(), return {});
if (!qmlItemNode.isValid())
return qmlItemNode.id();
if (m_qmlItemNode.instanceParent().modelNode() == qmlItemNode) if (m_qmlItemNode.instanceParent().modelNode() == qmlItemNode)
return QStringLiteral("parent"); return QStringLiteral("parent");