From 4bddce64f5880c8e26d1e9fc2cfe444b1d1358d5 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 18 Nov 2024 14:15:50 +0100 Subject: [PATCH] Qnx: Remove unused commandFound() method Task-number: QTCREATORBUG-29168 Change-Id: Ifad415adfcfa06f6152d39112e576bdc18487a6b Reviewed-by: hjk --- src/plugins/qnx/slog2inforunner.cpp | 12 +----------- src/plugins/qnx/slog2inforunner.h | 5 ----- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/plugins/qnx/slog2inforunner.cpp b/src/plugins/qnx/slog2inforunner.cpp index b7ed28ffd21..2c7bf6716c8 100644 --- a/src/plugins/qnx/slog2inforunner.cpp +++ b/src/plugins/qnx/slog2inforunner.cpp @@ -38,10 +38,6 @@ void Slog2InfoRunner::start() process.setCommand(CommandLine{device()->filePath("slog2info")}); }; const auto onTestDone = [this](DoneWith result) { - if (result == DoneWith::Success) { - m_found = true; - return; - } appendMessage(Tr::tr("Warning: \"slog2info\" is not found on the device, " "debug output not available."), ErrorMessageFormat); }; @@ -51,7 +47,6 @@ void Slog2InfoRunner::start() }; const auto onLaunchTimeDone = [this](const Process &process) { QTC_CHECK(!m_applicationId.isEmpty()); - QTC_CHECK(m_found); m_launchDateTime = QDateTime::fromString(process.cleanedStdOut().trimmed(), "dd HH:mm:ss"); }; @@ -70,7 +65,7 @@ void Slog2InfoRunner::start() }; const Group root { - ProcessTask(onTestSetup, onTestDone), + ProcessTask(onTestSetup, onTestDone, CallDoneIf::Error), ProcessTask(onLaunchTimeSetup, onLaunchTimeDone, CallDoneIf::Success), ProcessTask(onLogSetup, onLogError, CallDoneIf::Error) }; @@ -86,11 +81,6 @@ void Slog2InfoRunner::stop() reportStopped(); } -bool Slog2InfoRunner::commandFound() const -{ - return m_found; -} - void Slog2InfoRunner::processRemainingLogData() { if (!m_remainingData.isEmpty()) diff --git a/src/plugins/qnx/slog2inforunner.h b/src/plugins/qnx/slog2inforunner.h index 663be2ce69e..e77fa661079 100644 --- a/src/plugins/qnx/slog2inforunner.h +++ b/src/plugins/qnx/slog2inforunner.h @@ -19,20 +19,15 @@ public: void start() override; void stop() override; - bool commandFound() const; - private: void processRemainingLogData(); void processLogInput(const QString &input); void processLogLine(const QString &line); QString m_applicationId; - QDateTime m_launchDateTime; - bool m_found = false; bool m_currentLogs = false; QString m_remainingData; - Tasking::TaskTreeRunner m_taskTreeRunner; };