feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Add clean step only if the minSDK is changed

Browse Source 
Task-number: QTCREATORBUG-15533
Change-Id: If78b5c7f379e590ec7c0bbeb53dd9b45343f64b8
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@theqtcompany.com>
This commit is contained in:
BogDan Vatra
2016-01-05 16:40:22 +02:00
parent e22f8e37e4
commit 4c16632f8e
3 changed files with 31 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/plugins/qmakeandroidsupport/androidqmakebuildconfigurationfactory.cpp
View File

@@ -34,7 +34,10 @@
#include <android/androidmanager.h> #include <android/androidmanager.h>
#include <android/androidconfigurations.h> #include <android/androidconfigurations.h>
#include <projectexplorer/buildmanager.h>
#include <projectexplorer/buildsteplist.h> #include <projectexplorer/buildsteplist.h>
#include <projectexplorer/projectexplorer.h>
#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectexplorerconstants.h>
#include <qmakeprojectmanager/qmakebuildinfo.h> #include <qmakeprojectmanager/qmakebuildinfo.h>
@@ -110,6 +113,27 @@ AndroidQmakeBuildConfiguration::AndroidQmakeBuildConfiguration(ProjectExplorer::
void AndroidQmakeBuildConfiguration::addToEnvironment(Utils::Environment &env) const void AndroidQmakeBuildConfiguration::addToEnvironment(Utils::Environment &env) const
{ {
env.set(QLatin1String("ANDROID_NDK_PLATFORM"), m_androidNdkPlatform = Android::AndroidConfigurations::currentConfig().bestNdkPlatformMatch(Android::AndroidManager::minimumSDK(target()));
Android::AndroidConfigurations::currentConfig().bestNdkPlatformMatch(Android::AndroidManager::minimumSDK(target()))); env.set(QLatin1String("ANDROID_NDK_PLATFORM"), m_androidNdkPlatform);
}
void AndroidQmakeBuildConfiguration::manifestSaved()
{
using QmakeProjectManager::QMakeStep;
QString androidNdkPlatform = Android::AndroidConfigurations::currentConfig().bestNdkPlatformMatch(Android::AndroidManager::minimumSDK(target()));
if (m_androidNdkPlatform == androidNdkPlatform)
return;
emitEnvironmentChanged();
QMakeStep *qs = qmakeStep();
if (!qs)
return;
qs->setForced(true);
ProjectExplorer::BuildManager::buildList(stepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN),
ProjectExplorer::ProjectExplorerPlugin::displayNameForStepId(ProjectExplorer::Constants::BUILDSTEPS_CLEAN));
ProjectExplorer::BuildManager::appendStep(qs, ProjectExplorer::ProjectExplorerPlugin::displayNameForStepId(ProjectExplorer::Constants::BUILDSTEPS_CLEAN));
setSubNodeBuild(0);
} }

3
src/plugins/qmakeandroidsupport/androidqmakebuildconfigurationfactory.h
View File

@@ -61,8 +61,11 @@ public:
AndroidQmakeBuildConfiguration(ProjectExplorer::Target *target, AndroidQmakeBuildConfiguration *source); AndroidQmakeBuildConfiguration(ProjectExplorer::Target *target, AndroidQmakeBuildConfiguration *source);
AndroidQmakeBuildConfiguration(ProjectExplorer::Target *target, Core::Id id); AndroidQmakeBuildConfiguration(ProjectExplorer::Target *target, Core::Id id);
void addToEnvironment(Utils::Environment &env) const; void addToEnvironment(Utils::Environment &env) const;
void manifestSaved();
using BuildConfiguration::emitEnvironmentChanged; using BuildConfiguration::emitEnvironmentChanged;
private:
mutable QString m_androidNdkPlatform;
}; };
} // namespace Internal } // namespace Internal

24
src/plugins/qmakeandroidsupport/qmakeandroidsupport.cpp
View File

@@ -36,17 +36,9 @@
#include <android/androidconstants.h> #include <android/androidconstants.h>
#include <android/androidglobal.h> #include <android/androidglobal.h>
#include <projectexplorer/buildmanager.h>
#include <projectexplorer/buildsteplist.h>
#include <projectexplorer/deployconfiguration.h>
#include <projectexplorer/projectexplorer.h>
#include <projectexplorer/projectexplorerconstants.h>
#include <projectexplorer/target.h> #include <projectexplorer/target.h>
#include <qtsupport/qtkitinformation.h> #include <qtsupport/qtkitinformation.h>
#include <qmakeprojectmanager/qmakebuildconfiguration.h>
#include <qmakeprojectmanager/qmakenodes.h>
#include <qmakeprojectmanager/qmakeproject.h> #include <qmakeprojectmanager/qmakeproject.h>
#include <qmakeprojectmanager/qmakestep.h>
using namespace QmakeProjectManager; using namespace QmakeProjectManager;
@@ -136,20 +128,8 @@ Utils::FileName QmakeAndroidSupport::androiddeployJsonPath(ProjectExplorer::Targ
void QmakeAndroidSupport::manifestSaved(const ProjectExplorer::Target *target) void QmakeAndroidSupport::manifestSaved(const ProjectExplorer::Target *target)
{ {
ProjectExplorer::BuildConfiguration *bc = target->activeBuildConfiguration(); ProjectExplorer::BuildConfiguration *bc = target->activeBuildConfiguration();
if (auto qbc = qobject_cast<AndroidQmakeBuildConfiguration *>(bc)) { if (auto qbc = qobject_cast<AndroidQmakeBuildConfiguration *>(bc))
qbc->emitEnvironmentChanged(); qbc->manifestSaved();
QMakeStep *qs = qbc->qmakeStep();
if (!qs)
return;
qs->setForced(true);
ProjectExplorer::BuildManager::buildList(bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN),
ProjectExplorer::ProjectExplorerPlugin::displayNameForStepId(ProjectExplorer::Constants::BUILDSTEPS_CLEAN));
ProjectExplorer::BuildManager::appendStep(qs, ProjectExplorer::ProjectExplorerPlugin::displayNameForStepId(ProjectExplorer::Constants::BUILDSTEPS_CLEAN));
qbc->setSubNodeBuild(0);
}
} }
Utils::FileName QmakeAndroidSupport::manifestSourcePath(const ProjectExplorer::Target *target) Utils::FileName QmakeAndroidSupport::manifestSourcePath(const ProjectExplorer::Target *target)