feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Rename StopWithDone -> StopWithSuccess

Browse Source 
Make naming consistent with recent changes.
"Done" is meant to be an event name when the task / group
finishes. "Done" may finish with "Success" or an "Error".

This addresses the 26th point in the task below.

Task-number: QTCREATORBUG-28741
Change-Id: I53ed6905b1c385c398f49e122e8ca60aa3ad0806
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2023-11-04 12:57:23 +01:00
parent 2c0a59384c
commit 4c38f68d0f
29 changed files with 64 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/solutions/tasking/tasktree.h
View File

@@ -127,7 +127,7 @@ Q_ENUM_NS(WorkflowPolicy);
enum class SetupResult
{
Continue,
StopWithDone,
StopWithSuccess,
StopWithError
};
Q_ENUM_NS(SetupResult);
@@ -352,10 +352,10 @@ private:
static_assert(isBool || isVoid,
"Sync element: The synchronous function has to return void or bool.");
if constexpr (isBool) {
return onGroupSetup([function] { return function() ? SetupResult::StopWithDone
return onGroupSetup([function] { return function() ? SetupResult::StopWithSuccess
: SetupResult::StopWithError; });
}
return onGroupSetup([function] { function(); return SetupResult::StopWithDone; });
return onGroupSetup([function] { function(); return SetupResult::StopWithSuccess; });
};
};