From 4c7032fb1e56a8816585dbd1748f799abaccdd65 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 9 Nov 2020 11:33:30 +0100 Subject: [PATCH] Make CppProjectUdpater a final class Silence the warning: "Call to virtual method 'CppProjectUdpater::cancel' during destruction bypasses virtual dispatch". CppProjectUpdater's d'tor calls cancelAndWaitForFinished(), and the latter calls in turn virtual cancel() method. As long as we don't have subclasses of CppProjectUdpater, calling a virtual cancel() from the d'tor should be safe. Change-Id: If2ebe6a190649319401d4e4b0f6977f547c51dac Reviewed-by: Eike Ziller --- src/plugins/cpptools/cppprojectupdater.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/cpptools/cppprojectupdater.h b/src/plugins/cpptools/cppprojectupdater.h index 5d95fa087cf..8167b071cf0 100644 --- a/src/plugins/cpptools/cppprojectupdater.h +++ b/src/plugins/cpptools/cppprojectupdater.h @@ -47,7 +47,7 @@ public: Q_INVOKABLE CppTools::CppProjectUpdaterInterface *create(); }; -class CPPTOOLS_EXPORT CppProjectUpdater : public QObject, public CppProjectUpdaterInterface +class CPPTOOLS_EXPORT CppProjectUpdater final : public QObject, public CppProjectUpdaterInterface { Q_OBJECT