feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix compile warnings about missing overrides

Browse Source 
Add missing overrides.
Remove validateCurrentPage() completely,
since it didn't do anything useful.
This method is not overridden in any superclass up to QWizard.

Task-number: QTCREATORBUG-24098
Change-Id: Iffa335c471469c56e830b6160da49359fc5d6bc2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2020-11-23 16:44:16 +01:00
parent 5d602466a5
commit 4c9361124d
3 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/designer/cpp/formclasswizard.h
View File

@@ -44,9 +44,10 @@ public:
QString formSuffix() const; QString formSuffix() const;
private: private:
Core::BaseFileWizard *create(QWidget *parent, const Core::WizardDialogParameters &parameters) const; Core::BaseFileWizard *create(QWidget *parent,
const Core::WizardDialogParameters &parameters) const override;
Core::GeneratedFiles generateFiles(const QWizard *w, QString *errorMessage) const; Core::GeneratedFiles generateFiles(const QWizard *w, QString *errorMessage) const override;
}; };
} // namespace Internal } // namespace Internal

5
src/plugins/designer/cpp/formclasswizarddialog.cpp
View File

@@ -62,11 +62,6 @@ void FormClassWizardDialog::setPath(const QString &p)
m_classPage->setPath(p); m_classPage->setPath(p);
} }
bool FormClassWizardDialog::validateCurrentPage()
{
return QWizard::validateCurrentPage();
}
void FormClassWizardDialog::initializePage(int id) void FormClassWizardDialog::initializePage(int id)
{ {
Core::BaseFileWizard::initializePage(id); Core::BaseFileWizard::initializePage(id);

4
src/plugins/designer/cpp/formclasswizarddialog.h
View File

@@ -50,10 +50,8 @@ public:
Designer::FormClassWizardParameters parameters() const; Designer::FormClassWizardParameters parameters() const;
bool validateCurrentPage();
protected: protected:
void initializePage(int id); void initializePage(int id) override;
private: private:
FormTemplateWizardPage *m_formPage = nullptr; FormTemplateWizardPage *m_formPage = nullptr;