feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Fix inverse condition

Browse Source 
compare returns 0 when the strings are equal

Change-Id: I4dfd3b402d48a3043e9674f1d82e66c968e8ba94
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Orgad Shaneh
2016-10-22 21:10:00 +03:00
committed by Tobias Hunger
parent 28325aa446
commit 4ca1fb0e9a
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/bazaar/bazaarclient.cpp
+1 -1
View File
@@ -176,7 +176,7 @@ VcsBaseEditorWidget *BazaarClient::annotate(
bool BazaarClient::isVcsDirectory(const FileName &fileName) const bool BazaarClient::isVcsDirectory(const FileName &fileName) const
{ {
return fileName.toFileInfo().isDir() return fileName.toFileInfo().isDir()
&& fileName.fileName().compare(Constants::BAZAARREPO, HostOsInfo::fileNameCaseSensitivity()); && !fileName.fileName().compare(Constants::BAZAARREPO, HostOsInfo::fileNameCaseSensitivity());
} }
QString BazaarClient::findTopLevelForFile(const QFileInfo &file) const QString BazaarClient::findTopLevelForFile(const QFileInfo &file) const
src/plugins/cvs/cvscontrol.cpp
+1 -1
View File
@@ -58,7 +58,7 @@ Core::Id CvsControl::id() const
bool CvsControl::isVcsFileOrDirectory(const Utils::FileName &fileName) const bool CvsControl::isVcsFileOrDirectory(const Utils::FileName &fileName) const
{ {
return fileName.toFileInfo().isDir() return fileName.toFileInfo().isDir()
&& fileName.fileName().compare("CVS", Utils::HostOsInfo::fileNameCaseSensitivity()); && !fileName.fileName().compare("CVS", Utils::HostOsInfo::fileNameCaseSensitivity());
} }
bool CvsControl::isConfigured() const bool CvsControl::isConfigured() const
src/plugins/git/gitversioncontrol.cpp
+1 -1
View File
@@ -79,7 +79,7 @@ Core::Id GitVersionControl::id() const
bool GitVersionControl::isVcsFileOrDirectory(const Utils::FileName &fileName) const bool GitVersionControl::isVcsFileOrDirectory(const Utils::FileName &fileName) const
{ {
return fileName.toFileInfo().isDir() return fileName.toFileInfo().isDir()
&& fileName.fileName().compare(".git", Utils::HostOsInfo::fileNameCaseSensitivity()); && !fileName.fileName().compare(".git", Utils::HostOsInfo::fileNameCaseSensitivity());
} }
bool GitVersionControl::isConfigured() const bool GitVersionControl::isConfigured() const
src/plugins/mercurial/mercurialclient.cpp
+1 -1
View File
@@ -337,7 +337,7 @@ void MercurialClient::revertAll(const QString &workingDir, const QString &revisi
bool MercurialClient::isVcsDirectory(const FileName &fileName) const bool MercurialClient::isVcsDirectory(const FileName &fileName) const
{ {
return fileName.toFileInfo().isDir() return fileName.toFileInfo().isDir()
&& fileName.fileName().compare(Constants::MERCURIALREPO, HostOsInfo::fileNameCaseSensitivity()); && !fileName.fileName().compare(Constants::MERCURIALREPO, HostOsInfo::fileNameCaseSensitivity());
} }
void MercurialClient::view(const QString &source, const QString &id, void MercurialClient::view(const QString &source, const QString &id,
src/plugins/subversion/subversionplugin.cpp
+1 -1
View File
@@ -414,7 +414,7 @@ bool SubversionPlugin::isVcsDirectory(const FileName &fileName)
const QString baseName = fileName.fileName(); const QString baseName = fileName.fileName();
return fileName.toFileInfo().isDir() return fileName.toFileInfo().isDir()
&& contains(m_svnDirectories, [baseName](const QString &s) { && contains(m_svnDirectories, [baseName](const QString &s) {
return baseName.compare(s, HostOsInfo::fileNameCaseSensitivity()); return !baseName.compare(s, HostOsInfo::fileNameCaseSensitivity());
}); });
} }