From 4d11977bb724a719f6e699fef061fdbc989ef5c5 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Thu, 29 Aug 2013 11:04:09 +0200 Subject: [PATCH] Reduce usage of QStringRef::toString() in the QML profiler. Change-Id: Id246bea7c21c61c87d02e3a839b44617e24d58fc Reviewed-by: Aurindam Jana --- src/plugins/qmlprofiler/qmlprofilertracefile.cpp | 13 ++++++------- src/plugins/qmlprofiler/qv8profilerdatamodel.cpp | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/plugins/qmlprofiler/qmlprofilertracefile.cpp b/src/plugins/qmlprofiler/qmlprofilertracefile.cpp index c8405c3d3ce..0da6a4a8537 100644 --- a/src/plugins/qmlprofiler/qmlprofilertracefile.cpp +++ b/src/plugins/qmlprofiler/qmlprofilertracefile.cpp @@ -136,15 +136,14 @@ bool QmlProfilerFileReader::load(QIODevice *device) while (validVersion && !stream.atEnd() && !stream.hasError()) { QXmlStreamReader::TokenType token = stream.readNext(); - QString elementName = stream.name().toString(); + const QStringRef elementName = stream.name(); switch (token) { case QXmlStreamReader::StartDocument : continue; case QXmlStreamReader::StartElement : { if (elementName == _("trace")) { QXmlStreamAttributes attributes = stream.attributes(); if (attributes.hasAttribute(_("version"))) - validVersion = attributes.value(_("version")).toString() - == _(PROFILER_FILE_VERSION); + validVersion = attributes.value(_("version")) == _(PROFILER_FILE_VERSION); else validVersion = false; if (attributes.hasAttribute(_("traceStart"))) @@ -187,7 +186,7 @@ bool QmlProfilerFileReader::load(QIODevice *device) void QmlProfilerFileReader::loadEventData(QXmlStreamReader &stream) { - QTC_ASSERT(stream.name().toString() == _("eventData"), return); + QTC_ASSERT(stream.name() == _("eventData"), return); QXmlStreamAttributes attributes = stream.attributes(); if (attributes.hasAttribute(_("totalTime"))) { @@ -208,7 +207,7 @@ void QmlProfilerFileReader::loadEventData(QXmlStreamReader &stream) while (!stream.atEnd() && !stream.hasError()) { QXmlStreamReader::TokenType token = stream.readNext(); - const QString elementName = stream.name().toString(); + const QStringRef elementName = stream.name(); switch (token) { case QXmlStreamReader::StartElement: { @@ -294,11 +293,11 @@ void QmlProfilerFileReader::loadEventData(QXmlStreamReader &stream) void QmlProfilerFileReader::loadProfilerDataModel(QXmlStreamReader &stream) { - QTC_ASSERT(stream.name().toString() == _("profilerDataModel"), return); + QTC_ASSERT(stream.name() == _("profilerDataModel"), return); while (!stream.atEnd() && !stream.hasError()) { QXmlStreamReader::TokenType token = stream.readNext(); - const QString elementName = stream.name().toString(); + const QStringRef elementName = stream.name(); switch (token) { case QXmlStreamReader::StartElement: { diff --git a/src/plugins/qmlprofiler/qv8profilerdatamodel.cpp b/src/plugins/qmlprofiler/qv8profilerdatamodel.cpp index 406d010e80a..fd45bc0e476 100644 --- a/src/plugins/qmlprofiler/qv8profilerdatamodel.cpp +++ b/src/plugins/qmlprofiler/qv8profilerdatamodel.cpp @@ -354,7 +354,7 @@ void QV8ProfilerDataModel::load(QXmlStreamReader &stream) while (!stream.atEnd() && !stream.hasError()) { QXmlStreamReader::TokenType token = stream.readNext(); - QString elementName = stream.name().toString(); + const QStringRef elementName = stream.name(); switch (token) { case QXmlStreamReader::StartDocument : continue; case QXmlStreamReader::StartElement : {