feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Un-protect ProjectNode constructor

Browse Source 
Not much protection needed, and not provided either, as seen in
the removed workarounds.

Change-Id: Ib33f6481cdb04481c0324bdeb57eb50143ecb62f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-02-25 18:35:34 +01:00
parent 65be7c2915
commit 4d2981b1f4
4 changed files with 6 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/project.cpp
View File

@@ -958,12 +958,6 @@ public:
bool needsConfiguration() const final { return false; }
};
class TestProjectNode : public ProjectNode
{
public:
TestProjectNode(const Utils::FileName &dir) : ProjectNode(dir) { }
};
void ProjectExplorerPlugin::testProject_setup()
{
TestProject project;
@@ -1060,7 +1054,7 @@ void ProjectExplorerPlugin::testProject_parsingFail()
std::unique_ptr<ProjectNode> createFileTree(Project *project)
{
std::unique_ptr<ProjectNode> root = std::make_unique<TestProjectNode>(project->projectDirectory());
std::unique_ptr<ProjectNode> root = std::make_unique<ProjectNode>(project->projectDirectory());
std::vector<std::unique_ptr<FileNode>> nodes;
nodes.emplace_back(std::make_unique<FileNode>(TEST_PROJECT_PATH, FileType::Project));
nodes.emplace_back(std::make_unique<FileNode>(TEST_PROJECT_CPP_FILE, FileType::Source));
@@ -1080,7 +1074,7 @@ void ProjectExplorerPlugin::testProject_projectTree()
QCOMPARE(fileSpy.count(), 0);
QVERIFY(!project.rootProjectNode());
project.setRootProjectNode(std::make_unique<TestProjectNode>(project.projectDirectory()));
project.setRootProjectNode(std::make_unique<ProjectNode>(project.projectDirectory()));
QCOMPARE(fileSpy.count(), 0);
QVERIFY(!project.rootProjectNode());