feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Drop .exists() check in some FilePath functions

Browse Source 
... when it is implicit by other checks in the same expression.

Change-Id: I10c6bd92e4890bdf611f3a222dc6c2d271e98f37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-09-30 16:27:55 +02:00
parent 2373c69e47
commit 4d3374d23a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libs/utils/filepath.cpp
View File

@@ -616,7 +616,7 @@ bool FilePath::isWritableFile() const
return s_deviceHooks.isWritableFile(*this); return s_deviceHooks.isWritableFile(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isWritable() && !fi.isDir(); return fi.isWritable() && !fi.isDir();
} }
bool FilePath::ensureWritableDir() const bool FilePath::ensureWritableDir() const
@@ -626,7 +626,7 @@ bool FilePath::ensureWritableDir() const
return s_deviceHooks.ensureWritableDir(*this); return s_deviceHooks.ensureWritableDir(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
if (exists() && fi.isDir() && fi.isWritable()) if (fi.isDir() && fi.isWritable())
return true; return true;
return QDir().mkpath(m_data); return QDir().mkpath(m_data);
} }
@@ -652,7 +652,7 @@ bool FilePath::isExecutableFile() const
return s_deviceHooks.isExecutableFile(*this); return s_deviceHooks.isExecutableFile(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isExecutable() && !fi.isDir(); return fi.isExecutable() && !fi.isDir();
} }
bool FilePath::isReadableFile() const bool FilePath::isReadableFile() const
@@ -662,7 +662,7 @@ bool FilePath::isReadableFile() const
return s_deviceHooks.isReadableFile(*this); return s_deviceHooks.isReadableFile(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isReadable() && !fi.isDir(); return fi.isReadable() && !fi.isDir();
} }
bool FilePath::isReadableDir() const bool FilePath::isReadableDir() const
@@ -672,7 +672,7 @@ bool FilePath::isReadableDir() const
return s_deviceHooks.isReadableDir(*this); return s_deviceHooks.isReadableDir(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isReadable() && fi.isDir(); return fi.isReadable() && fi.isDir();
} }
bool FilePath::isFile() const bool FilePath::isFile() const
@@ -682,7 +682,7 @@ bool FilePath::isFile() const
return s_deviceHooks.isFile(*this); return s_deviceHooks.isFile(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isFile(); return fi.isFile();
} }
bool FilePath::isDir() const bool FilePath::isDir() const
@@ -692,7 +692,7 @@ bool FilePath::isDir() const
return s_deviceHooks.isDir(*this); return s_deviceHooks.isDir(*this);
} }
const QFileInfo fi{m_data}; const QFileInfo fi{m_data};
return fi.exists() && fi.isDir(); return fi.isDir();
} }
bool FilePath::createDir() const bool FilePath::createDir() const