From 4d8d0f01d8ec4ee7ddcf03482ace9583ea1016d1 Mon Sep 17 00:00:00 2001 From: Tim Jenssen Date: Mon, 5 Dec 2016 19:35:41 +0100 Subject: [PATCH] QmlDesigner: reduce some warnings Change-Id: Ied3597d32dc5c29de0d4caee78662342d28445cc Reviewed-by: Tobias Hunger --- .../connectioneditor/delegates.cpp | 24 +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/delegates.cpp b/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/delegates.cpp index e2a3c370efe..cf9c5b6f7e0 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/delegates.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/connectioneditor/delegates.cpp @@ -204,21 +204,13 @@ QWidget *DynamicPropertiesDelegate::createEditor(QWidget *parent, const QStyleOp } model->connectionView()->allModelNodes(); -// PropertiesComboBox *dynamicPropertiesComboBox = qobject_cast(widget); - -// if (!dynamicPropertiesComboBox) { -// return widget; -// } - - BindingProperty bindingProperty = model->bindingPropertyForRow(index.row()); - switch (index.column()) { case DynamicPropertiesModel::TargetModelNodeRow: { return 0; //no editor - } break; + }; case DynamicPropertiesModel::PropertyNameRow: { return QStyledItemDelegate::createEditor(parent, option, index); - } break; + }; case DynamicPropertiesModel::PropertyTypeRow: { PropertiesComboBox *dynamicPropertiesComboBox = new PropertiesComboBox(parent); @@ -237,10 +229,10 @@ QWidget *DynamicPropertiesDelegate::createEditor(QWidget *parent, const QStyleOp dynamicPropertiesComboBox->addItem(QLatin1String("color")); dynamicPropertiesComboBox->addItem(QLatin1String("variant")); return dynamicPropertiesComboBox; - } break; + }; case DynamicPropertiesModel::PropertyValueRow: { return QStyledItemDelegate::createEditor(parent, option, index); - } break; + }; default: qWarning() << "BindingDelegate::createEditor column" << index.column(); } @@ -348,16 +340,16 @@ QWidget *BackendDelegate::createEditor(QWidget *parent, const QStyleOptionViewIt emit delegate->commitData(backendComboBox); }); return backendComboBox; - } break; + }; case BackendModel::PropertyNameColumn: { return widget; - } break; + }; case BackendModel::IsSingletonColumn: { return 0; //no editor - } break; + }; case BackendModel::IsLocalColumn: { return 0; //no editor - } break; + }; default: qWarning() << "BackendDelegate::createEditor column" << index.column(); }