From 4e058a10b48cefa4841e9129d9bf7a99e05f3211 Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Tue, 25 Feb 2020 20:02:38 +0100 Subject: [PATCH] CMake Build: Fix linking PythonPlugin in Debug mode with MinGW PythonPlugin depends on LanguageClient, which has a private dependency on LanguageServerProtocol. This fixes this error: src/plugins/python/CMakeFiles/Python.dir/pythonrunconfiguration.cpp.obj: In function `int LanguageServerProtocol::JsonObject::typedValue(QString const&) const': src/libs/languageserverprotocol/jsonobject.h:134: undefined reference to `__imp__ZN22LanguageServerProtocol13fromJsonValueIiEET_RK10QJsonValue' Change-Id: I7cacbf68a00ff9ff2a6ab9618bc6ec371247a0aa Reviewed-by: Alessandro Portale --- src/plugins/languageclient/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/languageclient/CMakeLists.txt b/src/plugins/languageclient/CMakeLists.txt index d1910757dbc..abddb9cd968 100644 --- a/src/plugins/languageclient/CMakeLists.txt +++ b/src/plugins/languageclient/CMakeLists.txt @@ -1,5 +1,5 @@ add_qtc_plugin(LanguageClient - DEPENDS LanguageServerProtocol Qt5::Core + PUBLIC_DEPENDS LanguageServerProtocol Qt5::Core PLUGIN_DEPENDS ProjectExplorer Core TextEditor SOURCES client.cpp client.h