From 4e63191af991a6272507132f9849d7bc7c4be1c2 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 17 Jan 2025 15:48:59 +0100 Subject: [PATCH] CppEditor: Remove two unused signals Change-Id: Id521d92c0c4ae5c8d9aedd4177a8df444c3cb85d Reviewed-by: Christian Kandeler --- .../cppeditor/cppcodestylesettingspage.cpp | 2 -- .../cppeditor/cppcodestylesettingspage.h | 17 +++++++---------- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/src/plugins/cppeditor/cppcodestylesettingspage.cpp b/src/plugins/cppeditor/cppcodestylesettingspage.cpp index cc8a8bf5cbe..96be4549c6e 100644 --- a/src/plugins/cppeditor/cppcodestylesettingspage.cpp +++ b/src/plugins/cppeditor/cppcodestylesettingspage.cpp @@ -472,7 +472,6 @@ void CppCodeStylePreferencesWidget::slotCodeStyleSettingsChanged() current->setCodeStyleSettings(cppCodeStyleSettings()); } - emit codeStyleSettingsChanged(cppCodeStyleSettings()); updatePreview(); } @@ -487,7 +486,6 @@ void CppCodeStylePreferencesWidget::slotTabSettingsChanged(const TabSettings &se current->setTabSettings(settings); } - emit tabSettingsChanged(settings); updatePreview(); } diff --git a/src/plugins/cppeditor/cppcodestylesettingspage.h b/src/plugins/cppeditor/cppcodestylesettingspage.h index 279cf72ec1f..503ad363678 100644 --- a/src/plugins/cppeditor/cppcodestylesettingspage.h +++ b/src/plugins/cppeditor/cppcodestylesettingspage.h @@ -19,15 +19,14 @@ namespace TextEditor { class CodeStyleEditorWidget; } -namespace CppEditor { - -namespace Internal { +namespace CppEditor::Internal { class CppCodeStylePreferencesWidgetPrivate; class CppCodeStylePreferencesWidget : public TextEditor::CodeStyleEditorWidget { Q_OBJECT + public: explicit CppCodeStylePreferencesWidget(QWidget *parent = nullptr); ~CppCodeStylePreferencesWidget() override; @@ -37,6 +36,10 @@ public: void apply() override; void finish() override; +signals: + void applyEmitted(); + void finishEmitted(); + private: void decorateEditors(const TextEditor::FontSettings &fontSettings); void setVisualizeWhitespace(bool on); @@ -56,14 +59,8 @@ private: TextEditor::TabSettings m_originalTabSettings; bool m_blockUpdates = false; friend class CppCodeStylePreferencesWidgetPrivate; -signals: - void codeStyleSettingsChanged(const CppEditor::CppCodeStyleSettings &); - void tabSettingsChanged(const TextEditor::TabSettings &); - void applyEmitted(); - void finishEmitted(); }; void setupCppCodeStyleSettings(); -} // namespace Internal -} // namespace CppEditor +} // namespace CppEditor::Internal